You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/14 13:34:41 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1407: Fix various error in Windows native build

xiaoxiang781216 commented on code in PR #1407:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1407#discussion_r1021549899


##########
Application.mk:
##########
@@ -62,7 +62,10 @@ ifeq ($(BUILD_MODULE),y)
 endif
 
 SUFFIX = $(subst $(DELIM),.,$(CWD))
+
+ifeq ($(CONFIG_WINDOWS_NATIVE),)
 PROGNAME := $(shell echo $(PROGNAME))

Review Comment:
   can we change `$(subst ",,$(PROGNAME))` to avoid ifeq



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org