You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2024/02/02 16:16:40 UTC

[PR] Rely on DefaultScmRepositoryConfigurator for extracting credentials from [maven-scm-publish-plugin]

kwin opened a new pull request, #29:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/29

   server settings
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSCMPUBLISH) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MSCMPUBLISH-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSCMPUBLISH-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSCMPUB-63] Rely on DefaultScmRepositoryConfigurator for extracting credentials from [maven-scm-publish-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #29:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/29#issuecomment-1934248384

   That easy? No test necessary? Do ITs cover it already?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSCMPUB-63] Rely on DefaultScmRepositoryConfigurator for extracting credentials from [maven-scm-publish-plugin]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #29:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/29


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MSCMPUB-63] Rely on DefaultScmRepositoryConfigurator for extracting credentials from [maven-scm-publish-plugin]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #29:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/29#issuecomment-1934304575

   There is no IT deploying to an actual remote SCM. Only local SVN file URLs are being used. Those work without requiring credentials. Not sure if it is worth the effort to add a unit test for resolving of server settings....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org