You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by victorsosa <gi...@git.apache.org> on 2016/03/02 21:24:14 UTC

[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

GitHub user victorsosa opened a pull request:

    https://github.com/apache/struts/pull/89

    WW-4356  Implement new Sitemesh plugin based on Sitemesh3 - Sitemesh update 

        WW-4356
    
    Implement new Sitemesh plugin based on Sitemesh3
    
    sitemesh update

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/victorsosa/struts sitemesh_update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit e05f9f01804bc64ace15bfc573ef483da583e5a7
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-01-21T12:00:54Z

    Merge pull request #3 from apache/master
    
    update pull

commit 778eec3b94f283290f186c8caffd10f03576fa27
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-01-26T12:38:50Z

    Merge pull request #4 from apache/master
    
    update pull

commit 46bd92fe202041c76704b96d11a0b8f8e83d56de
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-01-29T21:54:27Z

    Merge pull request #5 from apache/master
    
    update pull

commit a2c5bc835ec06483af6175fc0abf67714fb28711
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-02-04T17:12:22Z

    Merge pull request #6 from apache/master
    
    pull update

commit c15c0bb0c7c2a7de897e032061476d0a0d75f1d2
Author: victorsosa <vi...@peopleware.do>
Date:   2016-03-02T20:20:51Z

        WW-4356

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa closed the pull request at:

    https://github.com/apache/struts/pull/89


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:

    https://github.com/apache/struts/pull/89#issuecomment-191425788
  
    I thought you did also some code cleanups/improvements :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the pull request:

    https://github.com/apache/struts/pull/89#issuecomment-216887974
  
    Closing this PR; I didn't get any support from this Sitemesh community; this project seems to be dead; there is not point on upgrade it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the pull request:

    https://github.com/apache/struts/pull/89#issuecomment-191471653
  
    for example VelocityPageFilter and FreemarkerPageFilter aren't used, right? and can be deleted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the pull request:

    https://github.com/apache/struts/pull/89#issuecomment-191426848
  
    I did'nt because I did not get any compile error here, weird; But I am working on it so the code compile 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request: WW-4356 Implement new Sitemesh plugin based o...

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:

    https://github.com/apache/struts/pull/89#issuecomment-191428715
  
    ok, I just wanted to throw away some code, maybe some duplicates, etc. but I'm not a Sitemesh expert :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org