[GitHub] [airflow] jedcunningham commented on a diff in pull request #27419: Add webserverConfigConfigmapName

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #27419:
URL: https://github.com/apache/airflow/pull/27419#discussion_r1038425424


##########
tests/charts/test_webserver.py:
##########
@@ -738,6 +750,45 @@ def test_webserver_config_configmap(self):
             == jmespath.search('data."webserver_config.py"', docs[0]).strip()
         )
 
+    def test_webserver_config_configmap_name_volume_mounts(self):
+        configmap_name = "my-configmap"
+        docs = render_chart(
+            values={
+                "scheduler": {"logGroomerSidecar": {"enabled": True}, "waitForMigrations": {"enabled": True}},
+                "triggerer": {"waitForMigrations": {"enabled": True}},

Review Comment:
   Sorry, let me be more clear. All of these are already true by default, you don't need to set them explicitly here, and they will still be tested.
   
   e.g. [scheduler.logGroomerSidecar.enabled](https://github.com/apache/airflow/blob/19f1e5bf4b9544ae9775ebd8c57797335be53ed6/chart/values.yaml#L722), [scheduler.waitForMigrations.enabled](https://github.com/apache/airflow/blob/19f1e5bf4b9544ae9775ebd8c57797335be53ed6/chart/values.yaml#L739), [triggerer.waitForMigrations.enabled](https://github.com/apache/airflow/blob/19f1e5bf4b9544ae9775ebd8c57797335be53ed6/chart/values.yaml#L1129)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org