You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Henrique Mendonca (Updated) (JIRA)" <ji...@apache.org> on 2012/03/21 19:31:40 UTC
[jira] [Updated] (THRIFT-1353) Switch to performance branch, get
rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca updated THRIFT-1353:
--------------------------------------
Attachment: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
I had a look on Wade's changes ages ago and they seemed to be very nicely done. Since he seems to be no longer reachable I'm submitting the re-based patch in his name. Plus some minor changes on the tests.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
This fixes the problems with Int64 as well as improves the buffered transport impl. and also remove the use of the slow binary parser as he says above.
There is still a lot to do on the nodejs library but this is a great addiction. Could anyone test/commit this?
By the way, does anyone knows how we can install node on the jenkins slave?
Cheers!
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira