You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/23 16:16:09 UTC
[GitHub] [camel-k] orpiske opened a new pull request, #3566: Add preliminary support for the resume API
orpiske opened a new pull request, #3566:
URL: https://github.com/apache/camel-k/pull/3566
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske merged pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske merged PR #3566:
URL: https://github.com/apache/camel-k/pull/3566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on code in PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#discussion_r953379181
##########
pkg/apis/camel/v1/common_types.go:
##########
@@ -304,6 +304,8 @@ const (
CapabilityTracing = "tracing"
// CapabilityMaster defines the master capability
CapabilityMaster = "master"
+ // CapabilityResume defines the resume capability
+ CapabilityResume = "resume-kafka"
Review Comment:
I guess this need to be scoped as we did for the runtime i.e. CapabilityResumeKafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1226778399
Hey @lburgazzoli, any other comments about this code? I'd like to merge it today if possible / good enough ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1226861517
True, we can easily create a new PR with the generated doc. There are still some issue to polish on camel k runtime, so, we still have time to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1225357712
> +1
>
> We have some documentation here: https://camel.apache.org/components/next/eips/resume-strategies.html. I think it needs some documentation about the trait + a link to that page.
That would be perfect, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1225358040
BTW, I am also working on some examples, similar to the ones I have for Camel Core. I plan to submit them to the examples repo once this is merged in and stabilized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1226790044
Thanks for the review @lburgazzoli and @squakez. I am going to merge this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1225356599
> A bit of usage documentation either in the same addon or externally in the official doc would be really appreciated. Without that, the user has no clue of what this is about...
👍
We have some documentation here: https://camel.apache.org/components/next/eips/resume-strategies.html. I think it needs some documentation about the trait + a link to that page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on a diff in pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske commented on code in PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#discussion_r953490341
##########
pkg/apis/camel/v1/common_types.go:
##########
@@ -304,6 +304,8 @@ const (
CapabilityTracing = "tracing"
// CapabilityMaster defines the master capability
CapabilityMaster = "master"
+ // CapabilityResume defines the resume capability
+ CapabilityResume = "resume-kafka"
Review Comment:
+1. I'll adjust. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1226828242
BTW, we need to add its entry to doc gen script and run `make generate` so that the addon doc is generated. Not sure if it's right time to do so though, as we are in the process of releasing 1.10.0.
https://github.com/apache/camel-k/blob/main/script/gen_doc.sh#L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] orpiske commented on pull request #3566: Add preliminary support for the resume API
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #3566:
URL: https://github.com/apache/camel-k/pull/3566#issuecomment-1224296368
@lburgazzoli FYI, this is to get us started and we can build from here. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org