You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/04 01:26:35 UTC

[GitHub] [skywalking] Snile826 commented on pull request #6316: Snile826 patch scriptes

Snile826 commented on pull request #6316:
URL: https://github.com/apache/skywalking/pull/6316#issuecomment-772954670


   - The shebang must be on the first line. Delete blanks and move comments.shellcheck(SC1128)
   - Use $(...) notation instead of legacy backticked `...`.shellcheck(SC2006)
   - Use 'cd ... || exit' or 'cd ... || return' in case cd fails.shellcheck(SC2164)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org