You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/26 22:41:12 UTC
[jira] [Commented] (GORA-461) Ineffective null check in
HBaseStore#getPartitions
[ https://issues.apache.org/jira/browse/GORA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258877#comment-15258877 ]
ASF GitHub Bot commented on GORA-461:
-------------------------------------
Github user renato2099 closed the pull request at:
https://github.com/apache/gora/pull/54
> Ineffective null check in HBaseStore#getPartitions
> --------------------------------------------------
>
> Key: GORA-461
> URL: https://issues.apache.org/jira/browse/GORA-461
> Project: Apache Gora
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Renato Javier MarroquĂn Mogrovejo
> Priority: Minor
>
> Here is related code:
> {code}
> Pair<byte[][], byte[][]> keys = table.getStartEndKeys();
> if (keys == null || keys.getFirst() == null ||
> keys.getFirst().length == 0) {
> throw new IOException("Expecting at least one region.");
> }
> if (table == null) {
> throw new IOException("No table was provided.");
> {code}
> The null check is ineffective since table has been de-referenced before the check.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)