You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/02/05 19:43:59 UTC
[jira] Created: (ZOOKEEPER-293) zoo_set needs to be abi compatible
(3.1 changed the signature), fix this by adding zoo_set2
zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2
-------------------------------------------------------------------------------------------
Key: ZOOKEEPER-293
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-293
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.1.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
Fix For: 3.1.0
ZOOKEEPER-255 fixed an issue with zoo_set not providing access to stat structure, however this has broken b/w compatibility with previous releases.
We need to:
1) revert zoo_set to not have stat parameter (keep b/w compat)
2) add zoo_set2 method with stat param added to the function signature
3) add a version.h file to src/c/include that provides zoo version detail to clients
ie.
> #define ZOO_MAJOR_VERSION 3
> #define ZOO_MINOR_VERSION 1
> #define ZOO_PATCH_VERSION 0
(a new jira should be added to centralize version numbering, we now have the version number in 3 places in the source)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-293) zoo_set needs to be abi compatible
(3.1 changed the signature), fix this by adding zoo_set2
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-293:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
Thanks pat.
> zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-293
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-293
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-293.patch
>
>
> ZOOKEEPER-255 fixed an issue with zoo_set not providing access to stat structure, however this has broken b/w compatibility with previous releases.
> We need to:
> 1) revert zoo_set to not have stat parameter (keep b/w compat)
> 2) add zoo_set2 method with stat param added to the function signature
> 3) add a version.h file to src/c/include that provides zoo version detail to clients
> ie.
> > #define ZOO_MAJOR_VERSION 3
> > #define ZOO_MINOR_VERSION 1
> > #define ZOO_PATCH_VERSION 0
> (a new jira should be added to centralize version numbering, we now have the version number in 3 places in the source)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-293) zoo_set needs to be abi
compatible (3.1 changed the signature), fix this by adding zoo_set2
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671103#action_12671103 ]
Hudson commented on ZOOKEEPER-293:
----------------------------------
Integrated in ZooKeeper-trunk #221 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/221/])
. zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2 (pat via mahadev)
> zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-293
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-293
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-293.patch
>
>
> ZOOKEEPER-255 fixed an issue with zoo_set not providing access to stat structure, however this has broken b/w compatibility with previous releases.
> We need to:
> 1) revert zoo_set to not have stat parameter (keep b/w compat)
> 2) add zoo_set2 method with stat param added to the function signature
> 3) add a version.h file to src/c/include that provides zoo version detail to clients
> ie.
> > #define ZOO_MAJOR_VERSION 3
> > #define ZOO_MINOR_VERSION 1
> > #define ZOO_PATCH_VERSION 0
> (a new jira should be added to centralize version numbering, we now have the version number in 3 places in the source)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-293) zoo_set needs to be abi
compatible (3.1 changed the signature), fix this by adding zoo_set2
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670871#action_12670871 ]
Mahadev konar commented on ZOOKEEPER-293:
-----------------------------------------
+1 for the patch ...
> zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-293
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-293
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-293.patch
>
>
> ZOOKEEPER-255 fixed an issue with zoo_set not providing access to stat structure, however this has broken b/w compatibility with previous releases.
> We need to:
> 1) revert zoo_set to not have stat parameter (keep b/w compat)
> 2) add zoo_set2 method with stat param added to the function signature
> 3) add a version.h file to src/c/include that provides zoo version detail to clients
> ie.
> > #define ZOO_MAJOR_VERSION 3
> > #define ZOO_MINOR_VERSION 1
> > #define ZOO_PATCH_VERSION 0
> (a new jira should be added to centralize version numbering, we now have the version number in 3 places in the source)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-293) zoo_set needs to be abi compatible
(3.1 changed the signature), fix this by adding zoo_set2
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-293:
-----------------------------------
Attachment: ZOOKEEPER-293.patch
Addressed the issues as desc.
> zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-293
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-293
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-293.patch
>
>
> ZOOKEEPER-255 fixed an issue with zoo_set not providing access to stat structure, however this has broken b/w compatibility with previous releases.
> We need to:
> 1) revert zoo_set to not have stat parameter (keep b/w compat)
> 2) add zoo_set2 method with stat param added to the function signature
> 3) add a version.h file to src/c/include that provides zoo version detail to clients
> ie.
> > #define ZOO_MAJOR_VERSION 3
> > #define ZOO_MINOR_VERSION 1
> > #define ZOO_PATCH_VERSION 0
> (a new jira should be added to centralize version numbering, we now have the version number in 3 places in the source)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-293) zoo_set needs to be abi compatible
(3.1 changed the signature), fix this by adding zoo_set2
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-293:
-----------------------------------
Status: Patch Available (was: Open)
> zoo_set needs to be abi compatible (3.1 changed the signature), fix this by adding zoo_set2
> -------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-293
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-293
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-293.patch
>
>
> ZOOKEEPER-255 fixed an issue with zoo_set not providing access to stat structure, however this has broken b/w compatibility with previous releases.
> We need to:
> 1) revert zoo_set to not have stat parameter (keep b/w compat)
> 2) add zoo_set2 method with stat param added to the function signature
> 3) add a version.h file to src/c/include that provides zoo version detail to clients
> ie.
> > #define ZOO_MAJOR_VERSION 3
> > #define ZOO_MINOR_VERSION 1
> > #define ZOO_PATCH_VERSION 0
> (a new jira should be added to centralize version numbering, we now have the version number in 3 places in the source)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.