[GitHub] [doris] yiguolei commented on a diff in pull request #20597: [Log](query) Add log of fragment instance num to recognize large query

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #20597:
URL: https://github.com/apache/doris/pull/20597#discussion_r1223888246


##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1371,6 +1371,18 @@ private void sendResult(boolean isOutfileQuery, boolean isSendFields, Queriable
         }
         profile.getSummaryProfile().setQueryScheduleFinishTime();
         updateProfile(false);
+        if (coord.getInstanceTotalNum() > 1) {
+            try {
+                LOG.debug("Start to execute fragment. user: {}, db: {}, sql: {}, fragment instance num: {}",

Review Comment:
   add  if  Log.isdebugenabled() because the sql maybe very long 
   in some cases it may cost a lot of memory or cpu time.



##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1449,6 +1461,16 @@ private void sendResult(boolean isOutfileQuery, boolean isSendFields, Queriable
             throw e;
         } finally {
             fetchResultSpan.end();
+            if (coord.getInstanceTotalNum() > 1) {
+                try {
+                    LOG.debug("Finish to execute fragment. user: {}, db: {}, sql: {}, fragment instance num: {}",

Review Comment:
   and here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org