You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Christoph John <ch...@macd.com.INVALID> on 2022/08/24 10:43:50 UTC
Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)
Hi Jonathan,
are you able to help me with the last item on the list (see quote below)?
Thank you in advance and best regards,
Chris.
On 28.07.22 16:42, Emmanuel Lécharny wrote:
> 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible? Please see here:
> https://github.com/quickfix-j/quickfixj/blob/c4c963cdb2a6c4f1942f12bcfd890bff166788c2/quickfixj-core/src/main/java/quickfix/mina/ssl/SSLFilter.java#L66-L78
>
> Good question. I don't know... Jonathan ?
>
>
--
Christoph John
Software Engineering
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
52066 Aachen, Germany
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)
Posted by Christoph John <ch...@macd.com.INVALID>.
Thanks, Jonathan.
On 27.08.22 20:05, Jonathan Valliere wrote:
> https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketSession.java#L94
>
> On Aug 26, 2022 at 5:15:42 AM, Christoph John <ch...@macd.com> wrote:
>> The constant PEER_ADDRESS is no longer present in the code in 2.2.x
>>
>> I can see however that in
>> https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L272
>> and
>> https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L239
>> the remoteAddress is used if it is not NULL.
>> But I am not able to find out where the remoteAddress is set on the IoSession.
>>
>> Cheers,
>> Chris.
>>
>> On 25.08.22 12:27, Jonathan Valliere wrote:
>>> It should be either doing it automatically or is a configurable option in
>>> the filter.
>>>
>>> I’m far away from my computer right now so I can’t check.
>>>
>>> On Wed, Aug 24, 2022 at 6:44 AM Christoph John<ch...@macd.com>
>>> wrote:
>>>
>>>> Hi Jonathan,
>>>>
>>>> are you able to help me with the last item on the list (see quote below)?
>>>>
>>>> Thank you in advance and best regards,
>>>> Chris.
>>>>
>>>> On 28.07.22 16:42, Emmanuel Lécharny wrote:
>>>>
>>>> 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible?
>>>> Please see here:
>>>> https://github.com/quickfix-j/quickfixj/blob/c4c963cdb2a6c4f1942f12bcfd890bff166788c2/quickfixj-core/src/main/java/quickfix/mina/ssl/SSLFilter.java#L66-L78
>>>>
>>>> Good question. I don't know... Jonathan ?
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Christoph John
>>>> Software Engineering
>>>> T +49 241557080-28christoph.john@macd.com
>>>>
>>>> MACD GmbHOppenhoffallee 103
>>>> 52066 Aachen, Germany<https://www.google.com/maps/search/Oppenhoffallee+103%0D%0A52066+Aachen,+Germany?entry=gmail&source=g>www.macd.com
>>>>
>>>> Amtsgericht Aachen: HRB 8151
>>>> Ust.-Id: DE 813021663
>>>> Geschäftsführer: George Macdonald
>>>>
>>>>
>>
>> --
>> Christoph John
>> Software Engineering
>> T +49 241 557080-28
>> christoph.john@macd.com
>>
>> MACD GmbH
>> Oppenhoffallee 103
>> 52066 Aachen, Germany
>> www.macd.com
>>
>> Amtsgericht Aachen: HRB 8151
>> Ust.-Id: DE 813021663
>> Geschäftsführer: George Macdonald
--
Christoph John
Software Engineering
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
52066 Aachen, Germany
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)
Posted by Jonathan Valliere <jo...@apache.org>.
https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketSession.java#L94
On Aug 26, 2022 at 5:15:42 AM, Christoph John <ch...@macd.com>
wrote:
> The constant PEER_ADDRESS is no longer present in the code in 2.2.x
>
> I can see however that in
> https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L272
> and
> https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L239
> the remoteAddress is used if it is not NULL.
> But I am not able to find out where the remoteAddress is set on the
> IoSession.
>
> Cheers,
> Chris.
>
> On 25.08.22 12:27, Jonathan Valliere wrote:
>
> It should be either doing it automatically or is a configurable option in
> the filter.
>
> I’m far away from my computer right now so I can’t check.
>
> On Wed, Aug 24, 2022 at 6:44 AM Christoph John <ch...@macd.com> <ch...@macd.com>
> wrote:
>
>
> Hi Jonathan,
>
> are you able to help me with the last item on the list (see quote below)?
>
> Thank you in advance and best regards,
> Chris.
>
> On 28.07.22 16:42, Emmanuel Lécharny wrote:
>
> 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible?
> Please see here:https://github.com/quickfix-j/quickfixj/blob/c4c963cdb2a6c4f1942f12bcfd890bff166788c2/quickfixj-core/src/main/java/quickfix/mina/ssl/SSLFilter.java#L66-L78
>
> Good question. I don't know... Jonathan ?
>
>
>
>
>
>
> --
> Christoph John
> Software Engineering
> T +49 241 557080-28christoph.john@macd.com
>
> MACD GmbHOppenhoffallee 103
> 52066 Aachen, Germany <https://www.google.com/maps/search/Oppenhoffallee+103%0D%0A52066+Aachen,+Germany?entry=gmail&source=g> <https://www.google.com/maps/search/Oppenhoffallee+103%0D%0A52066+Aachen,+Germany?entry=gmail&source=g>www.macd.com
>
> Amtsgericht Aachen: HRB 8151
> Ust.-Id: DE 813021663
> Geschäftsführer: George Macdonald
>
>
>
>
> --
> Christoph John
> Software Engineering
> T +49 241 557080-28christoph.john@macd.com
>
> MACD GmbH
> Oppenhoffallee 103
> 52066 Aachen, Germanywww.macd.com
>
> Amtsgericht Aachen: HRB 8151
> Ust.-Id: DE 813021663
> Geschäftsführer: George Macdonald
>
>
Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)
Posted by Christoph John <ch...@macd.com.INVALID>.
The constant PEER_ADDRESS is no longer present in the code in 2.2.x
I can see however that in
https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L272
and
https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L239
the remoteAddress is used if it is not NULL.
But I am not able to find out where the remoteAddress is set on the IoSession.
Cheers,
Chris.
On 25.08.22 12:27, Jonathan Valliere wrote:
> It should be either doing it automatically or is a configurable option in
> the filter.
>
> I’m far away from my computer right now so I can’t check.
>
> On Wed, Aug 24, 2022 at 6:44 AM Christoph John<ch...@macd.com>
> wrote:
>
>> Hi Jonathan,
>>
>> are you able to help me with the last item on the list (see quote below)?
>>
>> Thank you in advance and best regards,
>> Chris.
>>
>> On 28.07.22 16:42, Emmanuel Lécharny wrote:
>>
>> 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible?
>> Please see here:
>> https://github.com/quickfix-j/quickfixj/blob/c4c963cdb2a6c4f1942f12bcfd890bff166788c2/quickfixj-core/src/main/java/quickfix/mina/ssl/SSLFilter.java#L66-L78
>>
>> Good question. I don't know... Jonathan ?
>>
>>
>>
>>
>>
>>
>> --
>> Christoph John
>> Software Engineering
>> T +49 241557080-28christoph.john@macd.com
>>
>> MACD GmbHOppenhoffallee 103
>> 52066 Aachen, Germany<https://www.google.com/maps/search/Oppenhoffallee+103%0D%0A52066+Aachen,+Germany?entry=gmail&source=g>www.macd.com
>>
>> Amtsgericht Aachen: HRB 8151
>> Ust.-Id: DE 813021663
>> Geschäftsführer: George Macdonald
>>
>>
--
Christoph John
Software Engineering
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
52066 Aachen, Germany
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)
Posted by Jonathan Valliere <jo...@apache.org>.
It should be either doing it automatically or is a configurable option in
the filter.
I’m far away from my computer right now so I can’t check.
On Wed, Aug 24, 2022 at 6:44 AM Christoph John <ch...@macd.com>
wrote:
> Hi Jonathan,
>
> are you able to help me with the last item on the list (see quote below)?
>
> Thank you in advance and best regards,
> Chris.
>
> On 28.07.22 16:42, Emmanuel Lécharny wrote:
>
> 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible?
> Please see here:
> https://github.com/quickfix-j/quickfixj/blob/c4c963cdb2a6c4f1942f12bcfd890bff166788c2/quickfixj-core/src/main/java/quickfix/mina/ssl/SSLFilter.java#L66-L78
>
> Good question. I don't know... Jonathan ?
>
>
>
>
>
>
> --
> Christoph John
> Software Engineering
> T +49 241 557080-28christoph.john@macd.com
>
> MACD GmbHOppenhoffallee 103
> 52066 Aachen, Germany <https://www.google.com/maps/search/Oppenhoffallee+103%0D%0A52066+Aachen,+Germany?entry=gmail&source=g>www.macd.com
>
> Amtsgericht Aachen: HRB 8151
> Ust.-Id: DE 813021663
> Geschäftsführer: George Macdonald
>
>