You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/06 21:22:57 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3383: Made PR template checklist check-able by ALL PRs

ocket8888 opened a new pull request #3383: Made PR template checklist check-able by ALL PRs
URL: https://github.com/apache/trafficcontrol/pull/3383
 
 
   ## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
   The new PR template re-words the bottom checklist ('this pr includes documentation', 'updates Changelog.md' etc.) such that any PR that is ready for merging will have ALL boxes checked.
   
   It also changes the "Which TC components are affected by this PR?" section to an unordered list, the new recommendation being that unaffected components be removed from said list.
   
   All together, this results in a PR that's ready for review having a nice, happy "6/6" in the PR list.
   
   ## Which TC components are affected by this PR?
   This PR Template
   
   ## What is the best way to verify this PR? Please include manual steps or automated tests. 
   Just look at the template - no tests because no functionality.
   
   
   ## Check all that apply
   See, none of these are true, so this PR will show up as "0/6", which implies it's missing required pieces.
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services