You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/01/06 22:11:13 UTC
Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1661
https://issues.apache.org/jira/browse/OOZIE-1661
Repository: oozie-git
Description
-------
UI improvement - log streaming.
1. Support partial streaming of logs.
UI doesn't support partial displaying of logs, logs are displayed only when request completes.
2.Current ajax call timeout is 30 sec(except coord logs with action list).
If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
Changing it to no timeout. Timeout should be handled by Server.
3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
Adding a function to retrieve and display logs, will be used by all component.
4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
Diffs
-----
webapp/src/main/webapp/oozie-console.js e1b4588
Diff: https://reviews.apache.org/r/16669/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On Jan. 7, 2014, 10:46 p.m., Rohini Palaniswamy wrote:
> > webapp/src/main/webapp/oozie-console.js, line 37
> > <https://reviews.apache.org/r/16669/diff/2/?file=417637#file417637line37>
> >
> > space after full stop. Why reassign errorMsg if already present? Probably you meant !errorMsg
Sorry for that, i mean !errorMsg.
> On Jan. 7, 2014, 10:46 p.m., Rohini Palaniswamy wrote:
> > webapp/src/main/webapp/oozie-console.js, line 69
> > <https://reviews.apache.org/r/16669/diff/2/?file=417637#file417637line69>
> >
> > What is this for? Does not seem to be used and don't see such a field for XHR searching online.
This to get partial logs.
Changes the logic to store length, rather than storing full text.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/#review31314
-----------------------------------------------------------
On Jan. 8, 2014, 9:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16669/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 9:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1661
> https://issues.apache.org/jira/browse/OOZIE-1661
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> UI improvement - log streaming.
> 1. Support partial streaming of logs.
> UI doesn't support partial displaying of logs, logs are displayed only when request completes.
> 2.Current ajax call timeout is 30 sec(except coord logs with action list).
> If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
> Changing it to no timeout. Timeout should be handled by Server.
> 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
> Adding a function to retrieve and display logs, will be used by all component.
> 4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
> Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
>
>
> Diffs
> -----
>
> webapp/src/main/webapp/oozie-console.js e1b4588
>
> Diff: https://reviews.apache.org/r/16669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Jan. 7, 2014, 10:46 p.m., Rohini Palaniswamy wrote:
> > webapp/src/main/webapp/oozie-console.js, line 65
> > <https://reviews.apache.org/r/16669/diff/2/?file=417637#file417637line65>
> >
> > Should the condition be > 2 instead of = 4? Remember seeing that in the examples.
Verified that you need > 2. Only with 3 you get partial responses. Keeping == 4 will only get response once the request is complete.
State Description
0 The request is not initialized
1 The request has been set up
2 The request has been sent
3 The request is in process
4 The request is complete
http://stackoverflow.com/questions/632774/what-do-the-different-readystates-in-xmlhttprequest-mean-and-how-can-i-use-them
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/#review31314
-----------------------------------------------------------
On Jan. 8, 2014, 9:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16669/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 9:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1661
> https://issues.apache.org/jira/browse/OOZIE-1661
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> UI improvement - log streaming.
> 1. Support partial streaming of logs.
> UI doesn't support partial displaying of logs, logs are displayed only when request completes.
> 2.Current ajax call timeout is 30 sec(except coord logs with action list).
> If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
> Changing it to no timeout. Timeout should be handled by Server.
> 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
> Adding a function to retrieve and display logs, will be used by all component.
> 4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
> Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
>
>
> Diffs
> -----
>
> webapp/src/main/webapp/oozie-console.js e1b4588
>
> Diff: https://reviews.apache.org/r/16669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On Jan. 7, 2014, 10:46 p.m., Rohini Palaniswamy wrote:
> > webapp/src/main/webapp/oozie-console.js, line 65
> > <https://reviews.apache.org/r/16669/diff/2/?file=417637#file417637line65>
> >
> > Should the condition be > 2 instead of = 4? Remember seeing that in the examples.
>
> Rohini Palaniswamy wrote:
> Verified that you need > 2. Only with 3 you get partial responses. Keeping == 4 will only get response once the request is complete.
>
> State Description
> 0 The request is not initialized
> 1 The request has been set up
> 2 The request has been sent
> 3 The request is in process
> 4 The request is complete
>
> http://stackoverflow.com/questions/632774/what-do-the-different-readystates-in-xmlhttprequest-mean-and-how-can-i-use-them
Yes.. I was doing some testing and by mistake i left it as 4.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/#review31314
-----------------------------------------------------------
On Jan. 8, 2014, 9:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16669/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 9:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1661
> https://issues.apache.org/jira/browse/OOZIE-1661
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> UI improvement - log streaming.
> 1. Support partial streaming of logs.
> UI doesn't support partial displaying of logs, logs are displayed only when request completes.
> 2.Current ajax call timeout is 30 sec(except coord logs with action list).
> If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
> Changing it to no timeout. Timeout should be handled by Server.
> 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
> Adding a function to retrieve and display logs, will be used by all component.
> 4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
> Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
>
>
> Diffs
> -----
>
> webapp/src/main/webapp/oozie-console.js e1b4588
>
> Diff: https://reviews.apache.org/r/16669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/#review31314
-----------------------------------------------------------
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/16669/#comment59774>
space after full stop. Why reassign errorMsg if already present? Probably you meant !errorMsg
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/16669/#comment59776>
Should the condition be > 2 instead of = 4? Remember seeing that in the examples.
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/16669/#comment59777>
What is this for? Does not seem to be used and don't see such a field for XHR searching online.
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/16669/#comment59780>
Do not comment out. Remove it altogether. Also please set initial text on the textarea to
"Enter the list of actions in the format similar to 1,3-4,7-40 to get logs for specific coordinator actions. To get the log for the coordinator job, leave the actions field empty" so that users know leaving it empty will give coord job log
webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/16669/#comment59781>
Remove this empty if condition
- Rohini Palaniswamy
On Jan. 6, 2014, 9:11 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16669/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 9:11 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1661
> https://issues.apache.org/jira/browse/OOZIE-1661
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> UI improvement - log streaming.
> 1. Support partial streaming of logs.
> UI doesn't support partial displaying of logs, logs are displayed only when request completes.
> 2.Current ajax call timeout is 30 sec(except coord logs with action list).
> If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
> Changing it to no timeout. Timeout should be handled by Server.
> 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
> Adding a function to retrieve and display logs, will be used by all component.
> 4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
> Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
>
>
> Diffs
> -----
>
> webapp/src/main/webapp/oozie-console.js e1b4588
>
> Diff: https://reviews.apache.org/r/16669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/#review31398
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Jan. 8, 2014, 9:23 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16669/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 9:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1661
> https://issues.apache.org/jira/browse/OOZIE-1661
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> UI improvement - log streaming.
> 1. Support partial streaming of logs.
> UI doesn't support partial displaying of logs, logs are displayed only when request completes.
> 2.Current ajax call timeout is 30 sec(except coord logs with action list).
> If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
> Changing it to no timeout. Timeout should be handled by Server.
> 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
> Adding a function to retrieve and display logs, will be used by all component.
> 4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
> Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
>
>
> Diffs
> -----
>
> webapp/src/main/webapp/oozie-console.js e1b4588
>
> Diff: https://reviews.apache.org/r/16669/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 16669: [OOZIE-1661]UI improvement - log streaming.
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16669/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 9:23 p.m.)
Review request for oozie.
Changes
-------
Review comment.
Bugs: OOZIE-1661
https://issues.apache.org/jira/browse/OOZIE-1661
Repository: oozie-git
Description
-------
UI improvement - log streaming.
1. Support partial streaming of logs.
UI doesn't support partial displaying of logs, logs are displayed only when request completes.
2.Current ajax call timeout is 30 sec(except coord logs with action list).
If log fetch request takes more than 30 sec, connection is terminated by UI and logs are never displayed.
Changing it to no timeout. Timeout should be handled by Server.
3.Code reuse : Coord,bundle and WF have their own logic to fetch and display logs.
Adding a function to retrieve and display logs, will be used by all component.
4.For coord job logs, "action list" and "fetch logs" components are on bottom of page, hard to see for user.
Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" button.
Diffs (updated)
-----
webapp/src/main/webapp/oozie-console.js e1b4588
Diff: https://reviews.apache.org/r/16669/diff/
Testing
-------
Thanks,
Purshotam Shah