You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ifesdjeen (via GitHub)" <gi...@apache.org> on 2025/05/09 17:27:16 UTC
[PR] Test fixes may 9 [cassandra-accord]
ifesdjeen opened a new pull request, #190:
URL: https://github.com/apache/cassandra-accord/pull/190
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Test fixes may 9 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on PR #190:
URL: https://github.com/apache/cassandra-accord/pull/190#issuecomment-2867833543
merged with tweaks to imports and removed `System.out`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Test fixes may 9 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #190:
URL: https://github.com/apache/cassandra-accord/pull/190#discussion_r2082370772
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -18,26 +18,21 @@
package accord.local;
-import java.util.function.BiFunction;
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
import accord.api.RoutingKey;
+import accord.primitives.*;
import accord.primitives.Status.Durability;
-import accord.primitives.AbstractRanges;
-import accord.primitives.Participants;
-import accord.primitives.TxnId;
-import accord.primitives.Unseekables;
import accord.utils.Invariants;
import accord.utils.PersistentField;
import accord.utils.ReducingIntervalMap;
import accord.utils.ReducingRangeMap;
import accord.utils.async.AsyncResult;
import accord.utils.async.AsyncResults;
-import static accord.primitives.Status.Durability.MajorityOrInvalidated;
-import static accord.primitives.Status.Durability.NotDurable;
-import static accord.primitives.Status.Durability.UniversalOrInvalidated;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.function.BiFunction;
+
+import static accord.primitives.Status.Durability.*;
Review Comment:
`*` imports, we talked about avoiding these
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -18,26 +18,21 @@
package accord.local;
-import java.util.function.BiFunction;
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
import accord.api.RoutingKey;
+import accord.primitives.*;
import accord.primitives.Status.Durability;
-import accord.primitives.AbstractRanges;
-import accord.primitives.Participants;
-import accord.primitives.TxnId;
-import accord.primitives.Unseekables;
import accord.utils.Invariants;
import accord.utils.PersistentField;
import accord.utils.ReducingIntervalMap;
import accord.utils.ReducingRangeMap;
import accord.utils.async.AsyncResult;
import accord.utils.async.AsyncResults;
-import static accord.primitives.Status.Durability.MajorityOrInvalidated;
-import static accord.primitives.Status.Durability.NotDurable;
-import static accord.primitives.Status.Durability.UniversalOrInvalidated;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.function.BiFunction;
+
+import static accord.primitives.Status.Durability.*;
Review Comment:
`*` imports, we agreed about avoiding these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Test fixes may 9 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #190:
URL: https://github.com/apache/cassandra-accord/pull/190#discussion_r2082407560
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -18,26 +18,21 @@
package accord.local;
-import java.util.function.BiFunction;
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
import accord.api.RoutingKey;
+import accord.primitives.*;
Review Comment:
`*` imports, we agreed about avoiding these
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -33,6 +33,7 @@
import javax.annotation.Nullable;
+import accord.primitives.*;
Review Comment:
can you revert the star import?
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -155,6 +150,27 @@ private DurableBefore()
}
}
+ public boolean fullyContainedIn(DurableBefore other)
+ {
+ if (values == NO_OBJECTS)
+ return true;
+
+ for (int i = 0 ; i < values.length; i++)
+ {
+ if (values[i] != null &&
+ !other.foldlWithDefault(Ranges.of(starts[i].rangeFactory().newRange(starts[i], starts[i + 1])),
+ (v, a) -> {
+ System.out.println("v = " + v);
Review Comment:
remove `println`, its fine to use a logger but not stdout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Test fixes may 9 [cassandra-accord]
Posted by "ifesdjeen (via GitHub)" <gi...@apache.org>.
ifesdjeen commented on PR #190:
URL: https://github.com/apache/cassandra-accord/pull/190#issuecomment-2868834394
thank you @dcapwell!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Test fixes may 9 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell closed pull request #190: Test fixes may 9
URL: https://github.com/apache/cassandra-accord/pull/190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Test fixes may 9 [cassandra-accord]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #190:
URL: https://github.com/apache/cassandra-accord/pull/190#discussion_r2082370772
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -18,26 +18,21 @@
package accord.local;
-import java.util.function.BiFunction;
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
import accord.api.RoutingKey;
+import accord.primitives.*;
import accord.primitives.Status.Durability;
-import accord.primitives.AbstractRanges;
-import accord.primitives.Participants;
-import accord.primitives.TxnId;
-import accord.primitives.Unseekables;
import accord.utils.Invariants;
import accord.utils.PersistentField;
import accord.utils.ReducingIntervalMap;
import accord.utils.ReducingRangeMap;
import accord.utils.async.AsyncResult;
import accord.utils.async.AsyncResults;
-import static accord.primitives.Status.Durability.MajorityOrInvalidated;
-import static accord.primitives.Status.Durability.NotDurable;
-import static accord.primitives.Status.Durability.UniversalOrInvalidated;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.function.BiFunction;
+
+import static accord.primitives.Status.Durability.*;
Review Comment:
nit: `*` imports, we talked about avoiding those on the dev list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org