[GitHub] [helix] pkuwm commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #458: Fix missed callbacks in CurrentStates based RoutingTableProvider.
URL: https://github.com/apache/helix/pull/458#discussion_r322970159
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
 ##########
 @@ -595,6 +595,15 @@ public RouterUpdater(String clusterName, PropertyType sourceDataType) {
     @Override
     protected void handleEvent(ClusterEvent event) {
       NotificationContext changeContext = event.getAttribute(AttributeName.changeContext.name());
+      HelixConstants.ChangeType changeType = event.getAttribute(AttributeName.CHANGE_TYPE.name());
 
 Review comment:
   Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org