You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/11/27 19:45:33 UTC
Review Request 64093: Added operators for offer operation update
protobuf classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-8197
https://issues.apache.org/jira/browse/MESOS-8197
Repository: mesos
Description
-------
Added operators for offer operation update protobuf classes.
Diffs
-----
src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
Diff: https://reviews.apache.org/r/64093/diff/1/
Testing
-------
Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
Thanks,
Gaston Kleiman
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On Nov. 30, 2017, 1:40 p.m., Greg Mann wrote:
> > src/messages/messages.hpp
> > Lines 48-50 (patched)
> > <https://reviews.apache.org/r/64093/diff/2/?file=1902023#file1902023line48>
> >
> > `OfferOperationStatus` is defined in 'include/mesos/mesos.proto', so the correct place for its operators is 'include/mesos/type_utils.hpp'.
> >
> > Note that we also need operators for the V1 version - looks like these go in 'include/mesos/v1/mesos.hpp'.
I moved the v0 operators to `include/mesos/type_utils.hpp`.
There's nothing using the v1 operators, so I would only add them when they're necessary.
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192352
-----------------------------------------------------------
On Nov. 30, 2017, 3:22 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 3:22 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8197
> https://issues.apache.org/jira/browse/MESOS-8197
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added operators for offer operation update protobuf classes.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp a348c7df083324602d25f40069ad49e29f7918a5
> src/common/type_utils.cpp 3657d55ab2a052b5c659022e3fc264e748429d54
> src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
> src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
>
>
> Diff: https://reviews.apache.org/r/64093/diff/3/
>
>
> Testing
> -------
>
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192352
-----------------------------------------------------------
src/messages/messages.hpp
Lines 48-50 (patched)
<https://reviews.apache.org/r/64093/#comment270453>
`OfferOperationStatus` is defined in 'include/mesos/mesos.proto', so the correct place for its operators is 'include/mesos/type_utils.hpp'.
Note that we also need operators for the V1 version - looks like these go in 'include/mesos/v1/mesos.hpp'.
src/messages/messages.cpp
Lines 181 (patched)
<https://reviews.apache.org/r/64093/#comment270471>
Let's say "Status UUID" here to avoid confusion with the operation UUID.
src/messages/messages.cpp
Lines 186-191 (patched)
<https://reviews.apache.org/r/64093/#comment270474>
Let's try to disambiguate the two operation IDs here. Perhaps something like:
" for operation UUID <operation_uuid> (framework-supplied operation ID '<operation_id>')"
src/messages/messages.cpp
Lines 198 (patched)
<https://reviews.apache.org/r/64093/#comment270475>
s/in/on/
- Greg Mann
On Nov. 27, 2017, 7:45 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 7:45 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8197
> https://issues.apache.org/jira/browse/MESOS-8197
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added operators for offer operation update protobuf classes.
>
>
> Diffs
> -----
>
> src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
> src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
>
>
> Diff: https://reviews.apache.org/r/64093/diff/2/
>
>
> Testing
> -------
>
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 5:21 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Rebased.
Bugs: MESOS-8197
https://issues.apache.org/jira/browse/MESOS-8197
Repository: mesos
Description
-------
Added operators for offer operation update protobuf classes.
Diffs (updated)
-----
include/mesos/type_utils.hpp b786d0e1b887306e68561ce7c9907fa844d5786a
src/common/type_utils.cpp 8cc987c2fc8204873d075729e7e6087d200c7f85
src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
Diff: https://reviews.apache.org/r/64093/diff/6/
Changes: https://reviews.apache.org/r/64093/diff/5-6/
Testing
-------
Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
Thanks,
Gaston Kleiman
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 3:47 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
MaDe capitalization consistent.
Bugs: MESOS-8197
https://issues.apache.org/jira/browse/MESOS-8197
Repository: mesos
Description
-------
Added operators for offer operation update protobuf classes.
Diffs (updated)
-----
include/mesos/type_utils.hpp b786d0e1b887306e68561ce7c9907fa844d5786a
src/common/type_utils.cpp 1b466fcfd133b6fd0067668c7ba54d1ce80c8702
src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
Diff: https://reviews.apache.org/r/64093/diff/5/
Changes: https://reviews.apache.org/r/64093/diff/4-5/
Testing
-------
Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
Thanks,
Gaston Kleiman
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192755
-----------------------------------------------------------
Fix it, then Ship it!
src/messages/messages.cpp
Line 63 (original), 112 (patched)
<https://reviews.apache.org/r/64093/#comment271015>
Make capitalization ("Status" vs. "status") consistent across this overload and the one below.
- Greg Mann
On Dec. 2, 2017, 2:11 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2017, 2:11 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8197
> https://issues.apache.org/jira/browse/MESOS-8197
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added operators for offer operation update protobuf classes.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp d28d5384af95d1992ca32d3afcdd16d1de678005
> src/common/type_utils.cpp a27222139fa3c841fd8ade17b4d0210e7b7dfa4f
> src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
> src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
>
>
> Diff: https://reviews.apache.org/r/64093/diff/4/
>
>
> Testing
> -------
>
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 6:11 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed feedback.
Bugs: MESOS-8197
https://issues.apache.org/jira/browse/MESOS-8197
Repository: mesos
Description
-------
Added operators for offer operation update protobuf classes.
Diffs (updated)
-----
include/mesos/type_utils.hpp d28d5384af95d1992ca32d3afcdd16d1de678005
src/common/type_utils.cpp a27222139fa3c841fd8ade17b4d0210e7b7dfa4f
src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
Diff: https://reviews.apache.org/r/64093/diff/4/
Changes: https://reviews.apache.org/r/64093/diff/3-4/
Testing
-------
Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
Thanks,
Gaston Kleiman
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192554
-----------------------------------------------------------
src/messages/messages.cpp
Lines 132 (patched)
<https://reviews.apache.org/r/64093/#comment270792>
s/UUID/status UUID/
- Greg Mann
On Nov. 30, 2017, 11:22 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 11:22 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-8197
> https://issues.apache.org/jira/browse/MESOS-8197
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added operators for offer operation update protobuf classes.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp a348c7df083324602d25f40069ad49e29f7918a5
> src/common/type_utils.cpp 3657d55ab2a052b5c659022e3fc264e748429d54
> src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
> src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
>
>
> Diff: https://reviews.apache.org/r/64093/diff/3/
>
>
> Testing
> -------
>
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64093: Added operators for offer operation update
protobuf classes.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/
-----------------------------------------------------------
(Updated Nov. 30, 2017, 3:22 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Addressed comments.
Bugs: MESOS-8197
https://issues.apache.org/jira/browse/MESOS-8197
Repository: mesos
Description
-------
Added operators for offer operation update protobuf classes.
Diffs (updated)
-----
include/mesos/type_utils.hpp a348c7df083324602d25f40069ad49e29f7918a5
src/common/type_utils.cpp 3657d55ab2a052b5c659022e3fc264e748429d54
src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b
src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d
Diff: https://reviews.apache.org/r/64093/diff/3/
Changes: https://reviews.apache.org/r/64093/diff/2-3/
Testing
-------
Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
Thanks,
Gaston Kleiman