You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 17:41:40 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28808: Allow setting the name for the base container within K8s Pod Operator

jedcunningham commented on code in PR #28808:
URL: https://github.com/apache/airflow/pull/28808#discussion_r1067281656


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -272,6 +273,7 @@ def __init__(
         pod_runtime_info_envs: list[k8s.V1EnvVar] | None = None,
         termination_grace_period: int | None = None,
         configmaps: list[str] | None = None,
+        base_container_name: str = "base",

Review Comment:
   I think we should switch this back so the default is still coming from `BASE_CONTAINER_NAME`. This makes it possible to change the default instance wide, and it also means this is a feature that can ship in a minor release vs being a breaking change that requires a major version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org