You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by JJoe2 <gi...@git.apache.org> on 2016/10/31 17:28:51 UTC

[GitHub] log4net pull request #39: Added a unit test for AppSettingPatternConverter

GitHub user JJoe2 opened a pull request:

    https://github.com/apache/log4net/pull/39

    Added a unit test for AppSettingPatternConverter

    Unit test for PR #35 as requested.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JJoe2/log4net wip/AppSettings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/log4net/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit 9dcdfcd5253d05ef3cf9916c64be65bf756c6ed2
Author: JoeJoe <jo...@hotmail.com>
Date:   2016-10-31T17:25:19Z

    Added a unit test for AppSettingPatternConverter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net issue #39: Added a unit test for AppSettingPatternConverter

Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:

    https://github.com/apache/log4net/pull/39
  
    I had to patch the Nant build, all tests pass for me.
    
    Many thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] log4net pull request #39: Added a unit test for AppSettingPatternConverter

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/log4net/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---