You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/03/19 18:08:14 UTC
Review Request 66142: Added blank lines after multi-line logging
statements in `master.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66142/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Zhitao Li.
Repository: mesos
Description
-------
Added blank lines after multi-line logging statements in `master.cpp`.
Diffs
-----
src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
Diff: https://reviews.apache.org/r/66142/diff/1/
Testing
-------
Thanks,
Gaston Kleiman
Re: Review Request 66142: Added blank lines after multi-line logging
statements in `master.cpp`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66142/#review199499
-----------------------------------------------------------
PASS: Mesos patch 66142 was successfully built and tested.
Reviews applied: `['66142']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66142
- Mesos Reviewbot Windows
On March 19, 2018, 4:16 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66142/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 4:16 p.m.)
>
>
> Review request for mesos, Greg Mann and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blank lines after multi-line logging statements in `master.cpp`.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/66142/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66142: Added blank lines after multi-line logging
statements in `master.cpp`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66142/
-----------------------------------------------------------
(Updated March 19, 2018, 4:16 p.m.)
Review request for mesos, Greg Mann and Zhitao Li.
Changes
-------
Made this patch standalone.
Repository: mesos
Description
-------
Added blank lines after multi-line logging statements in `master.cpp`.
Diffs (updated)
-----
src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
Diff: https://reviews.apache.org/r/66142/diff/2/
Changes: https://reviews.apache.org/r/66142/diff/1-2/
Testing
-------
Thanks,
Gaston Kleiman
Re: Review Request 66142: Added blank lines after multi-line logging
statements in `master.cpp`.
Posted by Zhitao Li <zh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66142/#review199455
-----------------------------------------------------------
Ship it!
Ship It!
- Zhitao Li
On March 19, 2018, 11:08 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66142/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 11:08 a.m.)
>
>
> Review request for mesos, Greg Mann and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blank lines after multi-line logging statements in `master.cpp`.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/66142/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66142: Added blank lines after multi-line logging
statements in `master.cpp`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66142/#review199459
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63992, 63994, 65300, 64618, 65993, 65994, 66056, 66057, 66058, 66059, 66060, 66141, 66142]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 19, 2018, 6:08 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66142/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 6:08 p.m.)
>
>
> Review request for mesos, Greg Mann and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blank lines after multi-line logging statements in `master.cpp`.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/66142/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 66142: Added blank lines after multi-line logging
statements in `master.cpp`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66142/#review199453
-----------------------------------------------------------
PASS: Mesos patch 66142 was successfully built and tested.
Reviews applied: `['63992', '63994', '65300', '64618', '65993', '65994', '66056', '66057', '66058', '66059', '66060', '66141', '66142']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66142
- Mesos Reviewbot Windows
On March 19, 2018, 11:08 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66142/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 11:08 a.m.)
>
>
> Review request for mesos, Greg Mann and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added blank lines after multi-line logging statements in `master.cpp`.
>
>
> Diffs
> -----
>
> src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7
>
>
> Diff: https://reviews.apache.org/r/66142/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>