You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/01/15 14:49:51 UTC

Review Request 29923: Ambari-agent errors out, but starts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29923/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-9147
    https://issues.apache.org/jira/browse/AMBARI-9147


Repository: ambari


Description
-------

less /var/log/ambari-agent/ambari-agent.out 

Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ambari_agent/AlertSchedulerHandler.py", line 174, in __load_definitions
    with open(os.path.join(self.cachedir, self.FILENAME)) as fp:
IOError: [Errno 2] No such file or directory: '/var/lib/ambari-agent/cache/alerts/definitions.json'


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 11f7de3 

Diff: https://reviews.apache.org/r/29923/diff/


Testing
-------

Tests ok

Hadoop-QA will give -1 as there are no tests changes. They are not needed as the only thing changed is more meaningful message to logs


Thanks,

Yurii Shylov

Re: Review Request 29923: Ambari-agent errors out, but starts

Posted by Jonathan Hurley <jh...@hortonworks.com>.


> On Jan. 15, 2015, 11:19 a.m., Jonathan Hurley wrote:
> > Ship It!

Committed; the review can be closed.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29923/#review68263
-----------------------------------------------------------


On Jan. 15, 2015, 8:49 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29923/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 8:49 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-9147
>     https://issues.apache.org/jira/browse/AMBARI-9147
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> less /var/log/ambari-agent/ambari-agent.out 
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/AlertSchedulerHandler.py", line 174, in __load_definitions
>     with open(os.path.join(self.cachedir, self.FILENAME)) as fp:
> IOError: [Errno 2] No such file or directory: '/var/lib/ambari-agent/cache/alerts/definitions.json'
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 11f7de3 
> 
> Diff: https://reviews.apache.org/r/29923/diff/
> 
> 
> Testing
> -------
> 
> Tests ok
> 
> Hadoop-QA will give -1 as there are no tests changes. They are not needed as the only thing changed is more meaningful message to logs
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 29923: Ambari-agent errors out, but starts

Posted by Jonathan Hurley <jh...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29923/#review68263
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Jan. 15, 2015, 8:49 a.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29923/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 8:49 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-9147
>     https://issues.apache.org/jira/browse/AMBARI-9147
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> less /var/log/ambari-agent/ambari-agent.out 
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/AlertSchedulerHandler.py", line 174, in __load_definitions
>     with open(os.path.join(self.cachedir, self.FILENAME)) as fp:
> IOError: [Errno 2] No such file or directory: '/var/lib/ambari-agent/cache/alerts/definitions.json'
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 11f7de3 
> 
> Diff: https://reviews.apache.org/r/29923/diff/
> 
> 
> Testing
> -------
> 
> Tests ok
> 
> Hadoop-QA will give -1 as there are no tests changes. They are not needed as the only thing changed is more meaningful message to logs
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>

Re: Review Request 29923: Ambari-agent errors out, but starts

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29923/#review68251
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 15, 2015, 1:49 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29923/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 1:49 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-9147
>     https://issues.apache.org/jira/browse/AMBARI-9147
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> less /var/log/ambari-agent/ambari-agent.out 
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/ambari_agent/AlertSchedulerHandler.py", line 174, in __load_definitions
>     with open(os.path.join(self.cachedir, self.FILENAME)) as fp:
> IOError: [Errno 2] No such file or directory: '/var/lib/ambari-agent/cache/alerts/definitions.json'
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 11f7de3 
> 
> Diff: https://reviews.apache.org/r/29923/diff/
> 
> 
> Testing
> -------
> 
> Tests ok
> 
> Hadoop-QA will give -1 as there are no tests changes. They are not needed as the only thing changed is more meaningful message to logs
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>