You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by dp...@apache.org on 2025/01/16 15:58:47 UTC

(cordova-ios) branch master updated: refactor!(SPM): rename Swift package from CordovaLib to Cordova (#1520)

This is an automated email from the ASF dual-hosted git repository.

dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git


The following commit(s) were added to refs/heads/master by this push:
     new 7fa0b8c1 refactor!(SPM): rename Swift package from CordovaLib to Cordova (#1520)
7fa0b8c1 is described below

commit 7fa0b8c18193ed5ce3a326f64fc5f2740b656c8e
Author: Darryl Pogue <da...@dpogue.ca>
AuthorDate: Thu Jan 16 07:58:42 2025 -0800

    refactor!(SPM): rename Swift package from CordovaLib to Cordova (#1520)
    
    This ends up being less confusing for everyone because the resulting
    framework is named Cordova.framework and the header paths are all
    <Cordova/*.h> but currently you need to reference the Swift dependency
    as "CordovaLib" rather than "Cordova".
    
    As far as I can tell from a quick search of public Package.swift files
    on GitHub, nobody has actually consumed this as a Swift package, so any
    breakage should be minimal and we should take the opportunity to do this
    right as part of the major version bump.
---
 Package.swift                                   |  2 +-
 templates/project/App.xcodeproj/project.pbxproj | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Package.swift b/Package.swift
index d383c5e3..6571d093 100644
--- a/Package.swift
+++ b/Package.swift
@@ -28,7 +28,7 @@ let package = Package(
         .macCatalyst(.v13)
     ],
     products: [
-        .library(name: "CordovaLib", targets: ["Cordova"])
+        .library(name: "Cordova", targets: ["Cordova"])
     ],
     dependencies: [],
     targets: [
diff --git a/templates/project/App.xcodeproj/project.pbxproj b/templates/project/App.xcodeproj/project.pbxproj
index 3dc0e9bc..b10423b7 100755
--- a/templates/project/App.xcodeproj/project.pbxproj
+++ b/templates/project/App.xcodeproj/project.pbxproj
@@ -28,7 +28,7 @@
 		907F98562C06B87200D2D242 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 907F98552C06B87200D2D242 /* PrivacyInfo.xcprivacy */; };
 		907F98662C06BC1B00D2D242 /* config.xml in Resources */ = {isa = PBXBuildFile; fileRef = 907F98652C06BC1B00D2D242 /* config.xml */; };
 		907F986A2C06BCD300D2D242 /* www in Resources */ = {isa = PBXBuildFile; fileRef = 907F98692C06BCD300D2D242 /* www */; };
-		90A914592CA3D370003DB979 /* CordovaLib in Frameworks */ = {isa = PBXBuildFile; productRef = 90A914582CA3D370003DB979 /* CordovaLib */; };
+		90A914592CA3D370003DB979 /* Cordova in Frameworks */ = {isa = PBXBuildFile; productRef = 90A914582CA3D370003DB979 /* Cordova */; };
 		90BD9B7A2C06907D000DEBAB /* Base in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B792C06907D000DEBAB /* Base */; };
 		90BD9B7C2C06907E000DEBAB /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B7B2C06907E000DEBAB /* Assets.xcassets */; };
 		90BD9B7F2C06907E000DEBAB /* Base in Resources */ = {isa = PBXBuildFile; fileRef = 90BD9B7E2C06907E000DEBAB /* Base */; };
@@ -80,7 +80,7 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
-				90A914592CA3D370003DB979 /* CordovaLib in Frameworks */,
+				90A914592CA3D370003DB979 /* Cordova in Frameworks */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -190,7 +190,7 @@
 			);
 			name = App;
 			packageProductDependencies = (
-				90A914582CA3D370003DB979 /* CordovaLib */,
+				90A914582CA3D370003DB979 /* Cordova */,
 			);
 			productName = App;
 			productReference = 90BD9B6C2C06907D000DEBAB /* App.app */;
@@ -528,9 +528,9 @@
 /* End XCLocalSwiftPackageReference section */
 
 /* Begin XCSwiftPackageProductDependency section */
-		90A914582CA3D370003DB979 /* CordovaLib */ = {
+		90A914582CA3D370003DB979 /* Cordova */ = {
 			isa = XCSwiftPackageProductDependency;
-			productName = CordovaLib;
+			productName = Cordova;
 		};
 /* End XCSwiftPackageProductDependency section */
 	};


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org