You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/12/15 01:33:21 UTC
Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Libprocess: Reduced binary bloat due to 'mime'.
Diffs
-----
3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82
3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f
3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed
3rdparty/libprocess/src/mime.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/54768/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 54768: Libprocess: Reduced binary bloat due to
'mime'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/#review159261
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54768]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 15, 2016, 1:33 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54768/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 1:33 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Reduced binary bloat due to 'mime'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82
> 3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f
> 3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed
> 3rdparty/libprocess/src/mime.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 54768: Libprocess: Reduced binary bloat due to
'mime'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/
-----------------------------------------------------------
(Updated Dec. 19, 2016, 8:07 p.m.)
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Libprocess: Reduced binary bloat due to 'mime'.
Diffs
-----
3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82
3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f
3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed
3rdparty/libprocess/src/mime.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/54768/diff/
Testing (updated)
-------
Using `nm --print-size --size-sort --radix=d -C src/.libs/libmesos.so`:
Original:
`22440 W process::mime::initialize()`
After patch:
`6613 T process::mime::initialize()`
Thanks,
Joris Van Remoortere
Re: Review Request 54768: Libprocess: Reduced binary bloat due to
'mime'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/
-----------------------------------------------------------
(Updated Dec. 19, 2016, 5:39 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Used initializer list.
Repository: mesos
Description
-------
Libprocess: Reduced binary bloat due to 'mime'.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82
3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f
3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed
3rdparty/libprocess/src/mime.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/54768/diff/
Testing (updated)
-------
Using `nm --print-size --size-sort --radix=d -C src/.libs/libmesos.so`:
Original:
`22440 W process::mime::initialize()`
After patch:
`9076 T process::mime::initialize()`
Thanks,
Joris Van Remoortere
Re: Review Request 54768: Libprocess: Reduced binary bloat due to
'mime'.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54768/#review159256
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/mime.cpp (line 152)
<https://reviews.apache.org/r/54768/#comment230206>
Eh, let's do slightly better while we're at it.
```cpp
types.insert({
{".obj", "application/octet-stream"},
{".ra", "audio/x-pn-realaudio"},
...
});
```
- Michael Park
On Dec. 14, 2016, 5:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54768/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 5:33 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Reduced binary bloat due to 'mime'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 10f416387f3f5f9eeb7f8cc0f760299b1f1bfa82
> 3rdparty/libprocess/include/process/mime.hpp 2b8351a5c24670f8849f517903dcb60c0db3654f
> 3rdparty/libprocess/src/CMakeLists.txt a815a6b2360cbe0f244c090117ff948ef0db04ed
> 3rdparty/libprocess/src/mime.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>