[GitHub] [arrow] bkietz commented on a change in pull request #9267: ARROW-11277: [C++] Workaround macOS 10.11: don't default construct consts

[GitBox <gi...@apache.org>]

bkietz commented on a change in pull request #9267:
URL: https://github.com/apache/arrow/pull/9267#discussion_r560302275



##########
File path: cpp/src/arrow/dataset/expression.cc
##########
@@ -681,7 +681,7 @@ Result<Expression> FoldConstants(Expression expr) {
         if (std::all_of(call->arguments.begin(), call->arguments.end(),
                         [](const Expression& argument) { return argument.literal(); })) {
           // all arguments are literal; we can evaluate this subexpression *now*
-          static const Datum ignored_input;
+          static const Datum ignored_input = Datum{};

Review comment:
       https://github.com/bkietz/arrow/blob/17f2df78f1fa623d05dd01f245f8f65f828f510d/cpp/src/arrow/datum.h#L118-L119
   
   Datum has one already; resolution of that constructor is just failing here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org