You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/04/26 13:54:50 UTC
Review Request 58737: Reupload missing config files for Log Search
collections
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58737/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-20858
https://issues.apache.org/jira/browse/AMBARI-20858
Repository: ambari
Description
-------
Reupload only the missing configs during logseach start.
Do that after the first config upload has happened or if the configs/{collection} folder has already exist, then check the files one-by-one again and reupload if one of them is missing
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 3c5dcba
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java d058383
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 37375dc
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 256ddae
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 8693157
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 6964951
Diff: https://reviews.apache.org/r/58737/diff/1/
Testing
-------
in progress... (manually has already done with docker)
Thanks,
Oliver Szabo
Re: Review Request 58737: Reupload missing config files for Log Search
collections
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58737/
-----------------------------------------------------------
(Updated April 27, 2017, 10:08 a.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
done with testing
Bugs: AMBARI-20858
https://issues.apache.org/jira/browse/AMBARI-20858
Repository: ambari
Description
-------
Reupload only the missing configs during logseach start.
Do that after the first config upload has happened or if the configs/{collection} folder has already exist, then check the files one-by-one again and reupload if one of them is missing
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 3c5dcba
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java d058383
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 37375dc
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 256ddae
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 8693157
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 6964951
Diff: https://reviews.apache.org/r/58737/diff/1/
Testing (updated)
-------
done (manually has already done with docker)
Thanks,
Oliver Szabo
Re: Review Request 58737: Reupload missing config files for Log Search
collections
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58737/#review173047
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 26, 2017, 1:54 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58737/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 1:54 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20858
> https://issues.apache.org/jira/browse/AMBARI-20858
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Reupload only the missing configs during logseach start.
> Do that after the first config upload has happened or if the configs/{collection} folder has already exist, then check the files one-by-one again and reupload if one of them is missing
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 3c5dcba
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java d058383
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 37375dc
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 256ddae
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 8693157
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 6964951
>
>
> Diff: https://reviews.apache.org/r/58737/diff/1/
>
>
> Testing
> -------
>
> in progress... (manually has already done with docker)
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 58737: Reupload missing config files for Log Search
collections
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58737/#review173045
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On April 26, 2017, 1:54 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58737/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 1:54 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-20858
> https://issues.apache.org/jira/browse/AMBARI-20858
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Reupload only the missing configs during logseach start.
> Do that after the first config upload has happened or if the configs/{collection} folder has already exist, then check the files one-by-one again and reupload if one of them is missing
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 3c5dcba
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java d058383
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 37375dc
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java 256ddae
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 8693157
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 6964951
>
>
> Diff: https://reviews.apache.org/r/58737/diff/1/
>
>
> Testing
> -------
>
> in progress... (manually has already done with docker)
>
>
> Thanks,
>
> Oliver Szabo
>
>