You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Steven Caswell <st...@caswell.name> on 2002/07/17 03:58:42 UTC
[lang] PATCH exception Nestable interface, implementation classes, and test cases
The attached patch contains the revised Nestable interface,
implementation classes,
and test cases. The interface has been revised as discussed in recent
e-mails. I made
A few assumptions about specific functionaltiy, so those with an
interest in the interface, please review the javadoc comments.
I also refactored the test cases along method boundaries. All test cases
run successfully.
Steven Caswell
steven@caswell.name
RE: [lang] PATCH exception Nestable interface, implementation classes, and test cases (new [PATCH])
Posted by Steven Caswell <st...@caswell.name>.
Makes sense. Should have paid attention to the String index stuff. Here
is a patch that includes the renamed method and the revised
functionality. I also cleaned up the javadocs and rearranged the
arguments on the indexOfThrowable(Class, int) method for consistency
with other APIs.
Steven Caswell
steven@caswell.name
a.k.a Mungo Knotwise of Michel Delving
"One ring to rule them all, one ring to find them..."
> -----Original Message-----
> From: Stephen Colebourne [mailto:scolebourne@btopenworld.com]
> Sent: Wednesday, July 17, 2002 5:26 PM
> To: Jakarta Commons Developers List
> Subject: Re: [lang] PATCH exception Nestable interface,
> implementation classes, and test cases
>
>
> The exception functionality is mostly fine. My comments are:
>
> The interface change I would make would be to the getLength()
> method. This seems too unspecific a name. Maybe something
> like getThrowableCount() ??
>
> The functionality change I would make is to the index out of
> bounds handling. I would favour throwing an
> IndexOutOfBoundsException if the class is used wrongly,
> rather than absorbing invalid indices silently. This would
> bring the class in line with String, which was the intention.
>
> Stephen
>
> ----- Original Message -----
> From: "Henri Yandell" <ba...@generationjava.com>
> To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
> Sent: Wednesday, July 17, 2002 6:07 AM
> Subject: Re: [lang] PATCH exception Nestable interface,
> implementation classes, and test cases
>
>
> > Applied. Am not going to consider the assumptions about specific
> > functionality to hinder a promotion to Commons proper, however it
> > might hold off a beta release if people think the API is going to
> > change mightily, so would be good if those interested got
> their oar in
> > over the next day or two.
> >
> > Hen
> >
> > On Tue, 16 Jul 2002, Steven Caswell wrote:
> >
> > > The attached patch contains the revised Nestable interface,
> > > implementation classes, and test cases. The interface has been
> > > revised as discussed in recent e-mails. I made
> > > A few assumptions about specific functionaltiy, so those with an
> > > interest in the interface, please review the javadoc comments.
> > >
> > > I also refactored the test cases along method boundaries.
> All test
> > > cases run successfully.
> > >
> > >
> > > Steven Caswell
> > > steven@caswell.name
> > >
> > >
> > >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
> <mailto:commons-dev-> unsubscribe@jakarta.apache.org>
> For
> additional commands,
> e-mail: <ma...@jakarta.apache.org>
>
>
Re: [lang] PATCH exception Nestable interface, implementation classes, and test cases
Posted by Stephen Colebourne <sc...@btopenworld.com>.
The exception functionality is mostly fine. My comments are:
The interface change I would make would be to the getLength() method. This
seems too unspecific a name. Maybe something like getThrowableCount() ??
The functionality change I would make is to the index out of bounds
handling. I would favour throwing an IndexOutOfBoundsException if the class
is used wrongly, rather than absorbing invalid indices silently. This would
bring the class in line with String, which was the intention.
Stephen
----- Original Message -----
From: "Henri Yandell" <ba...@generationjava.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Wednesday, July 17, 2002 6:07 AM
Subject: Re: [lang] PATCH exception Nestable interface, implementation
classes, and test cases
> Applied. Am not going to consider the assumptions about specific
> functionality to hinder a promotion to Commons proper, however it might
> hold off a beta release if people think the API is going to change
> mightily, so would be good if those interested got their oar in over the
> next day or two.
>
> Hen
>
> On Tue, 16 Jul 2002, Steven Caswell wrote:
>
> > The attached patch contains the revised Nestable interface,
> > implementation classes,
> > and test cases. The interface has been revised as discussed in recent
> > e-mails. I made
> > A few assumptions about specific functionaltiy, so those with an
> > interest in the interface, please review the javadoc comments.
> >
> > I also refactored the test cases along method boundaries. All test cases
> > run successfully.
> >
> >
> > Steven Caswell
> > steven@caswell.name
> >
> >
> >
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [lang] PATCH exception Nestable interface, implementation classes,
and test cases
Posted by Henri Yandell <ba...@generationjava.com>.
Applied. Am not going to consider the assumptions about specific
functionality to hinder a promotion to Commons proper, however it might
hold off a beta release if people think the API is going to change
mightily, so would be good if those interested got their oar in over the
next day or two.
Hen
On Tue, 16 Jul 2002, Steven Caswell wrote:
> The attached patch contains the revised Nestable interface,
> implementation classes,
> and test cases. The interface has been revised as discussed in recent
> e-mails. I made
> A few assumptions about specific functionaltiy, so those with an
> interest in the interface, please review the javadoc comments.
>
> I also refactored the test cases along method boundaries. All test cases
> run successfully.
>
>
> Steven Caswell
> steven@caswell.name
>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>