You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by emopers <gi...@git.apache.org> on 2016/02/04 07:39:24 UTC
[GitHub] commons-bcel pull request: Flushing DataOutputStream before callin...
GitHub user emopers opened a pull request:
https://github.com/apache/commons-bcel/pull/3
Flushing DataOutputStream before calling toByteArray on the underlying ByteArrayOutputStream
When a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance,
it is recommended to flush or close the DataOutputStream before invoking the underlying instances's toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned for example [here](http://stackoverflow.com/questions/2984538/how-to-use-bytearrayoutputstream-and-dataoutputstream-simultaneously-java).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emopers/commons-bcel baos_101_final
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-bcel/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 6296aa33e01e33c81811f0853251c539cdbd61ad
Author: emopers <em...@gmail.com>
Date: 2016-02-04T06:31:45Z
Fixing Usage of DataOutputStream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-bcel pull request #3: Flushing DataOutputStream before calling toByt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-bcel/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org