[GitHub] [beam] TobKed commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR

[GitBox <gi...@apache.org>]

TobKed commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r450702973



##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
 # under the License.
 
 name: Cancel
-on: [push]
+on: [push, pull_request]

Review comment:
       In relation to : https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml#L21
   
   Push: when new commits are pushed to the specified branches. e.g. new merge commit on master appear. So it is possible to run rests without PR.
   Pull request: when PR to specified branch is created and then again when new commits appear in the PR.
   
   It is not critical since PR builds do not delete/upload anything to the GCS (push builds do), but I think it would be convenient to decrease queue by introducing such a small change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org