You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pradeep Kamath (JIRA)" <ji...@apache.org> on 2009/11/13 23:20:39 UTC

[jira] Created: (PIG-1094) Fix unit tests corresponding to source changes so far

Fix unit tests corresponding to source changes so far
-----------------------------------------------------

                 Key: PIG-1094
                 URL: https://issues.apache.org/jira/browse/PIG-1094
             Project: Pig
          Issue Type: Sub-task
            Reporter: Pradeep Kamath
            Assignee: Pradeep Kamath




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780325#action_12780325 ] 

Olga Natkovich commented on PIG-1094:
-------------------------------------

We should fix the failures as part of the patch that caused them. Now that we have the baseline, we should make sure that we don't introduce any new failures.

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai closed PIG-1094.
---------------------------


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: 0.7.0
>
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch, PIG-1094_7.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782191#action_12782191 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

Thanks Richard - the incremental patch has been committed on load-store-redesign branch

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1094:
------------------------------

    Attachment: PIG-1094_2.patch

This patch replaces Util.generateURI(String) with Util.generateURI(String, PigContext) to handle hadoopifying of test files.

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793286#action_12793286 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

+1, PIG-1094_4.patch checked in, thanks Richard!

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780312#action_12780312 ] 

Richard Ding commented on PIG-1094:
-----------------------------------

The change of PIG-879 added the following failure cases:

||Testcase Class||Testcase Method||Cause||
|TestLoad|testLoadRemoteRel|local mode needs to be fixed|
|TestLoad|testLoadRemoteRelScheme|local mode needs to be fixed| 
|TestLoad|testGlobChars|local mode needs to be fixed| 

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1094:
------------------------------

    Attachment: PIG-1094_7.patch

This patch fixed several failed test cases caused by removing "split by 'file'" from Pig Latin. 

Resutls of 'test-patch':

{code}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 9 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
{code}

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch, PIG-1094_7.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thejas M Nair updated PIG-1094:
-------------------------------

    Attachment: PIG-1094_6.patch

This patch replaces PIG-1094_5.patch

As per Pradeep's suggestion, keeping the check in WeightedRangePartitioner.java to ensure that input is empty if sample file is empty.
Also merged with latest changes in LSR branch.


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779630#action_12779630 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

Patch committed - here is the list of test cases which still fail with the cause :
||Testcase Class||Testcase Method||Cause||
|TestAlgebraicEvalLocal|testGroupCountWithMultipleFields|local mode needs to be fixed|
|TestAlgebraicEvalLocal|testSimpleCount|local mode needs to be fixed|
|TestAlgebraicEvalLocal|testGroupCount|local mode needs to be fixed|
|TestAlgebraicEvalLocal|testGroupReorderCount|local mode needs to be fixed|
|TestAlgebraicEvalLocal|testGroupUniqueColumnCount|local mode needs to be fixed|
|TestAlgebraicEvalLocal|testGroupDuplicateColumnCount|local mode needs to be fixed|
|TestBinaryStorage|testBinaryStorageWithAsciiData|streaming needs to be fixed|
|TestBinaryStorage|testBinaryStorageWithBinaryData|streaming needs to be fixed|
|TestBZip|testBzipInPig|bzip support in PigStorage needs to be fixed|
|TestBZip|testEmptyBzipInPig|bzip support in PigStorage needs to be fixed|
|TestCombiner|testLocal|local mode needs to be fixed|
|TestCommit|testCheckin1|order by needs to be fixed|
|TestCommit|testCheckin2|order by needs to be fixed|
|TestCounters|testMapOnly|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testMapOnlyBinStorage|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testMapReduceOnly|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testMapReduceOnlyBinStorage|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testMapCombineReduce|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testMapCombineReduceBinStorage|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testMultipleMRJobs|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestCounters|testLocal|Counter needs to be fixed (broken in hadoop 20.1 with new api?)|
|TestEvalPipeline2|testLimitedSortWithDump|order by needs to be fixed|
|TestEvalPipeline2|testLimitAfterSort|order by needs to be fixed|
|TestEvalPipeline2|testLimitAfterSortDesc|order by needs to be fixed|
|TestEvalPipeline2|testEmptySort|order by needs to be fixed|
|TestEvalPipelineLocal|testFunctionInsideFunction|local mode needs to be fixed|
|TestEvalPipelineLocal|testJoin|local mode needs to be fixed|
|TestEvalPipelineLocal|testDriverMethod|local mode needs to be fixed|
|TestEvalPipelineLocal|testMapLookup|local mode needs to be fixed|
|TestEvalPipelineLocal|testBagFunctionWithFlattening|local mode needs to be fixed|
|TestEvalPipelineLocal|testSortWithUDF|local mode needs to be fixed|
|TestEvalPipelineLocal|testDistinct|local mode needs to be fixed|
|TestEvalPipelineLocal|testNestedPlan|local mode needs to be fixed|
|TestEvalPipelineLocal|testNestedPlanWithExpressionAssignment|local mode needs to be fixed|
|TestEvalPipelineLocal|testLimit|local mode needs to be fixed|
|TestEvalPipelineLocal|testComplexData|local mode needs to be fixed|
|TestEvalPipelineLocal|testBinStorageDetermineSchema|local mode needs to be fixed|
|TestEvalPipelineLocal|testProjectBag|local mode needs to be fixed|
|TestEvalPipelineLocal|testBinStorageDetermineSchema2|local mode needs to be fixed|
|TestEvalPipelineLocal|testCogroupWithInputFromGroup|local mode needs to be fixed|
|TestEvalPipelineLocal|testUtf8Dump|local mode needs to be fixed|
|TestEvalPipelineLocal|testMapUDF|local mode needs to be fixed|
|TestEvalPipelineLocal|testLoadCtorArgs|local mode needs to be fixed|
|TestEvalPipelineLocal|testNestedPlanForCloning|local mode needs to be fixed|
|TestEvalPipelineLocal|testArithmeticCloning|local mode needs to be fixed|
|TestEvalPipelineLocal|testExpressionReUse|local mode needs to be fixed|
|TestEvalPipelineLocal|testIdentity|local mode needs to be fixed|
|TestEvalPipeline|testSortWithUDF|order by needs to be fixed|
|TestFinish|testFinishInMapLoc|local mode needs to be fixed|
|TestFinish|testFinishInReduceLoc|local mode needs to be fixed|
|TestForEachNestedPlanLocal|testInnerOrderBy|local node needs to be fixed|
|TestForEachNestedPlanLocal|testInnerLimit|local node needs to be fixed|
|TestFRJoin|testSortFRJoin|order by needs to be fixed|
|TestGrunt|testKeepGoing|streaming needs to be fixed|
|TestJoin|testDefaultJoin|local mode needs to be fixed|
|TestJoin|testJoinSchema|local mode needs to be fixed|
|TestJoin|testLeftOuterJoin|local mode needs to be fixed|
|TestJoin|testRightOuterJoin|local mode needs to be fixed|
|TestJoin|testFullOuterJoin|local mode needs to be fixed|
|TestJoin|testJoinTupleFieldKey|local mode needs to be fixed|
|TestJoin|testJoinNullTupleFieldKey|local mode needs to be fixed|
|TestLocal2|testUnion1|local mode needs to be fixed|
|TestLocal2|testUnion1WithNulls|local mode needs to be fixed|
|TestLocal2|testUnion2|local mode needs to be fixed|
|TestLocal2|testUnion2WithNulls|local mode needs to be fixed|
|TestLocal2|testJoin1|local mode needs to be fixed|
|TestLocal|testBigGroupAll|local mode needs to be fixed|
|TestLocal|testBigGroupAllWithNull|local mode needs to be fixed|
|TestLocal|testStoreFunction|local mode needs to be fixed|
|TestLocal|testStoreFunctionNoNulls|local mode needs to be fixed|
|TestLocal|testStoreFunctionWithNulls|local mode needs to be fixed|
|TestLocal|testQualifiedFunctions|local mode needs to be fixed|
|TestLocal|testQualifiedFunctionsWithNulls|local mode needs to be fixed|
|TestLocal|testDefinedFunctions|local mode needs to be fixed|
|TestLocal|testDefinedFunctionsNoNulls|local mode needs to be fixed|
|TestLocal|testDefinedFunctionsWithNulls|local mode needs to be fixed|
|TestMergeJoin|testMergeJoinSimplest|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinOnMultiFields|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinWithExpr|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinOutWithSchema|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinOutWithFilters|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinOutWithProjects|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinOutPipeline|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinWithNulls|Merge join needs to be fixed|
|TestMergeJoin|testMergeJoinWithMRBoundaryLater|Merge join needs to be fixed|
|TestMergeJoin|testEmptyRightFile|Merge join needs to be fixed|
|TestMergeJoin|testParallelism|Merge join needs to be fixed|
|TestMergeJoin|testIndexer|Merge join needs to be fixed|
|TestMergeJoin|testExpression|Merge join needs to be fixed|
|TestMRCompiler|testMergeJoin|Merge join needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithTwoStores|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithTwoStores2|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithTwoStores2Execs|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithThreeStores|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithThreeStores2|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithTwoLoads|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithTwoLoads2|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithExplain|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithDump|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithDescribe|local mode needs to be fixed|
|TestMultiQueryLocal|testMultiQueryWithIllustrate|local mode needs to be fixed|
|TestMultiQueryLocal|testStoreOrder|local mode needs to be fixed|
|TestMultiQuery|testMultiQueryWithSplitInMapAndMultiMerge|local mode needs to be fixed|
|TestPigContext|testSetProperties_way_num01|local mode needs to be fixed|
|TestPigContext|testSetProperties_way_num02|local mode needs to be fixed|
|TestPigContext|testSetProperties_way_num03|local mode needs to be fixed|
|TestPigContext|testImportList|not clear on the cause yet|
|TestPigScriptParser|testDefineUDF|local mode needs to be fixed|
|TestPigSplit|testSchemaWithSplit|order by needs to be fixed|
|TestPigStats|testBytesWritten_JIRA_1027|local mode needs to be fixed|
|TestSampleOptimizer|testOptimizerFired|order by needs to be fixed|
|TestSampleOptimizer|testEndToEnd|order by needs to be fixed|
|TestSampleOptimizer|testPoissonSampleOptimizer|skew join needs to be fixed|
|TestSkewedJoin|testSkewedJoinWithGroup|skew join needs to be fixed|
|TestSkewedJoin|testSkewedJoinWithNoProperties|skew join needs to be fixed|
|TestSkewedJoin|testSkewedJoinReducers|skew join needs to be fixed|
|TestSkewedJoin|testSkewedJoinMapKey|skew join needs to be fixed|
|TestSkewedJoin|testSkewedJoinKeyPartition|skew join needs to be fixed|
|TestSkewedJoin|testSkewedJoinNullKeys|skew join needs to be fixed|
|TestStore|testStore|local mode needs to be fixed|
|TestStore|testStoreComplexData|local mode needs to be fixed|
|TestStore|testStoreComplexDataWithNull|local mode needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreaming|streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreaming(TestStreamingLocal.java:114)|streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreamingWithOutputSchema|streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreamingWithOutputSchema(TestStreamingLocal.java:154)|streaming needs to be fixed|
|TestStreamingLocal|testSimpleReduceSideStreamingAfterFlatten|streaming needs to be fixed|
|TestStreamingLocal|testSimpleReduceSideStreamingAfterFlatten(TestStreamingLocal.java:198)|streaming needs to be fixed|
|TestStreamingLocal|testSimpleOrderedReduceSideStreamingAfterFlatten|streaming needs to be fixed|
|TestStreamingLocal|testSimpleOrderedReduceSideStreamingAfterFlatten(TestStreamingLocal.java:247)|streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreamingWithUnixPipes|streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreamingWithUnixPipes(TestStreamingLocal.java:285)|streaming needs to be fixed|
|TestStreamingLocal|testLocalNegativeLoadStoreOptimization|streaming needs to be fixed|
|TestStreamingLocal|testLocalNegativeLoadStoreOptimization(TestStreamingLocal.java:291)|streaming needs to be fixed|
|TestTypeCheckingValidator|testMapLookupCast|local mode needs to be fixed|
|TestUDFReturnMap|testUDFReturnMap_LocalMode|local mode needs to be fixed|
|TestUDFWithoutParameter|testUDFWithoutParameter|local mode needs to be fixed|


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784343#action_12784343 ] 

Olga Natkovich commented on PIG-1094:
-------------------------------------

+1

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath resolved PIG-1094.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7.0
     Hadoop Flags: [Incompatible change]

Marking this issuse as fixed since all unit tests except TestCounters now pass - TestCounters failure will be tracked in PIG-1203

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: 0.7.0
>
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch, PIG-1094_7.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1094:
------------------------------

    Attachment: PIG-1094_4.patch

This patch fixes the failed test (TestGrunt.testCD) by porting the missing code from trunk to branch and no new test is added.

Here is the output of running 'test-patch' manually:

{code}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

{code}



> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784355#action_12784355 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

PIG-1094_3.patch committed to load-store-redesign branch

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796316#action_12796316 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

+1 to PIG-1094_6.patch , patch committed - thanks Thejas!

Here is the output of test-patch for the same:

  [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec]
     [exec]
     [exec]


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch, PIG-1094_6.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thejas M Nair updated PIG-1094:
-------------------------------

    Attachment: PIG-1094_5.patch

This patch (PIG-1094_5.patch) fixes the order-by, skew-join and merge-join test failures.

TestPoissonSampleLoader.java - testNumSamples() - Unlike earlier version of sampler, if there are very few rows (3 in this case) only one sample is selected.
WeightedRangePartitioner.java - If the sample file is empty, there was a check to ensure that the input is also empty , using FileLocalizer.getSize(). Removed that check. Input location need not be a file. 
PoissonSampleLoader.java - additional comments, fixed indentation .
GetMemNumRows.java - handling the case where 2nd last column is null (while looking for the specially marked last tuple).


output of test-patch -
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch, PIG-1094_5.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-1094:
--------------------------------

    Attachment: PIG-1094_3.patch

Attached patch addresses more test failures.

Here is the session output from running ant "test-patch" target locally:

{noformat}
  [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 70 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 382 release audit warnings (more than the trunk's current 381 warnings).
     [exec] 

{noformat}

The release audit warnings are due to html issues with jdiff and can be ignored.

The list of tests which still fail are:
||Testcase class||Testcase method||Probable Cause||
|TestBinaryStorage|testBinaryStorageWithAsciiData|Streaming needs to be fixed|
|TestBinaryStorage|testBinaryStorageWithBinaryData|Streaming needs to be fixed|
|TestBZip|testBzipInPig|bzip needs to be fixed|
|TestBZip|testEmptyBzipInPig|bzip needs to be fixed|
|TestCounters|testMapOnly|Counters need to be fixed - dependent on hadoop|
|TestCounters|testMapOnlyBinStorage|Counters need to be fixed - dependent on hadoop|
|TestCounters|testMapReduceOnly|Counters need to be fixed - dependent on hadoop|
|TestCounters|testMapReduceOnlyBinStorage|Counters need to be fixed - dependent on hadoop|
|TestCounters|testMapCombineReduce|Counters need to be fixed - dependent on hadoop|
|TestCounters|testMapCombineReduceBinStorage|Counters need to be fixed - dependent on hadoop|
|TestCounters|testMultipleMRJobs|Counters need to be fixed - dependent on hadoop|
|TestCounters|testLocal|Counters need to be fixed - dependent on hadoop|
|TestEvalPipeline2|testEmptySort|order by related failure|
|TestGrunt|testCD|Reparsing logic needs to be fixed|
|TestHBaseStorage|testLoadFromHBase|HBaseStorage needs to be fixed for new load-store redesign|
|TestHBaseStorage|testBackwardsCompatibility|HBaseStorage needs to be fixed for new load-store redesign|
|TestMRCompiler|testMergeJoin|test needs to be updated per new Merge join implementation|
|TestMultiQuery|testMultiQueryPhase3StreamingInReducer2|Streaming needs to be fixed|
|TestPoissonSampleLoader|testComputeSamples|test needs to be updated per new Skew join code?|
|TestStreamingLocal|testSimpleMapSideStreaming|Streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreamingWithOutputSchema|Streaming needs to be fixed|
|TestStreamingLocal|testSimpleReduceSideStreamingAfterFlatten|Streaming needs to be fixed|
|TestStreamingLocal|testSimpleOrderedReduceSideStreamingAfterFlatten|Streaming needs to be fixed|
|TestStreamingLocal|testSimpleMapSideStreamingWithUnixPipes|Streaming needs to be fixed|
|TestStreamingLocal|testLocalNegativeLoadStoreOptimization|Streaming needs to be fixed|



> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-1094:
--------------------------------

    Attachment: PIG-1094.patch

Attached patch which fixes most test cases which are due to the core changes in load store interfaces. As noted in the description, the patch does not address specific test failures like those due to local mode, streaming etc not being fixed yet to work with the new load store redesign.

 * The patch ensures all tests now compile
 * The main changes were to ensure new interface methods are now used. Also in many tests were earlier running in local mode, now they have been changed to run in mapreduce mode - these are tests not specific to local mode - so the switch should not result in loss of any test coverage. 
 * The patch also fixes LoadCaster related changes to POCast and related tests
 * TestPigLineRecordReader.java and TestStreaming have been excluded from compile-test and test-core targets since local mode and streaming needs to be fixed for them to work

Here are the results from running test-patch ant target locally:
{noformat}
   [exec] 
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 77 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
{noformat}

I will add a comment separately on what tests still fail and which area of the code needs to be fixed to address them.

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779235#action_12779235 ] 

Olga Natkovich commented on PIG-1094:
-------------------------------------

+1.

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793747#action_12793747 ] 

Pradeep Kamath commented on PIG-1094:
-------------------------------------

Latest list of unit test failures on branch:

||Testcase class||Testcase Method||Probable Cause||
|TestEvalPipeline2|testEmptySort|order by|
|TestMRCompiler|testMergeJoin|merge join|
|TestPoissonSampleLoader|testComputeSamples|skew join|
|TestPruneColumn|testOrderBy3|Prune columns issue with order by|
|TestSkewedJoin|testSkewedJoinNullKeys|skew join|
|TestSkewedJoin|testSkewedJoinOuter|skew join|
|TestHBaseStorage|testLoadFromHBase|HBaseStorage needs to be fixed|
|TestHBaseStorage|testBackwardsCompatibility|HBaseStorage needs to be fixed|
|TestCounters|testMapOnly|Counters need to fixed - hadoop issue|
|TestCounters|testMapOnlyBinStorage|Counters need to fixed - hadoop issue|
|TestCounters|testMapReduceOnly|Counters need to fixed - hadoop issue|
|TestCounters|testMapReduceOnlyBinStorage|Counters need to fixed - hadoop issue|
|TestCounters|testMapCombineReduce|Counters need to fixed - hadoop issue|
|TestCounters|testMapCombineReduceBinStorage|Counters need to fixed - hadoop issue|
|TestCounters|testMultipleMRJobs|Counters need to fixed - hadoop issue|
|TestCounters|testLocal|Counters need to fixed - hadoop issue|


> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch, PIG-1094_2.patch, PIG-1094_3.patch, PIG-1094_4.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780352#action_12780352 ] 

Richard Ding commented on PIG-1094:
-----------------------------------

I should make it clear in my earlier comment that the new failure cases are all new test cases that test relative to absolute path conversion in local mode (which we didn't have before).  

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>         Attachments: PIG-1094.patch
>
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1094) Fix unit tests corresponding to source changes so far

Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pradeep Kamath updated PIG-1094:
--------------------------------

    Description: The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

> Fix unit tests corresponding to source changes so far
> -----------------------------------------------------
>
>                 Key: PIG-1094
>                 URL: https://issues.apache.org/jira/browse/PIG-1094
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>
> The check-in's so far on load-store-redesign branch have nor addressed unit test failures due to interface changes. This jira is to track the task of making the common case unit tests work with the new interfaces. Some aspects of the new proposal like using LoadCaster interface for casting, making local mode work have not been completed yet. Tests which are failing due to those reasons will not be fixed in this jira and addressed in the jiras corresponding to those tasks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.