You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2023/01/05 04:20:17 UTC
[GitHub] [incubator-eventmesh] jonyangx commented on a diff in pull request #2816: [ISSUE #2668] Method appears to call the same method on the same object redundantly [RemoteSubscribeEventProcessor]
jonyangx commented on code in PR #2816:
URL: https://github.com/apache/incubator-eventmesh/pull/2816#discussion_r1062097184
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteSubscribeEventProcessor.java:
##########
@@ -118,10 +110,7 @@ public void handler(HandlerService.HandlerSpecific handlerSpecific, HttpRequest
new TypeReference<HashMap<String, Object>>() {}
)).orElse(Maps.newHashMap());
Review Comment:
suggest use orElseGet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org