You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/05 03:06:16 UTC

[GitHub] [rocketmq-mqtt] tianliuliu commented on a diff in pull request #89: [ISSUE #22] Improving codeCov for mqtt.common

tianliuliu commented on code in PR #89:
URL: https://github.com/apache/rocketmq-mqtt/pull/89#discussion_r865525539


##########
mqtt-common/src/main/java/org/apache/rocketmq/mqtt/common/util/TopicUtils.java:
##########
@@ -31,7 +31,7 @@ public class TopicUtils {
      * @return
      */
     public static String normalizeTopic(String topic) {
-        if (topic == null) {
+        if (topic == null || topic.isEmpty()) {

Review Comment:
   may be use StringUtils.isBlank(topic) will be better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org