You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/09 01:50:03 UTC
[GitHub] [rocketmq] liwei0423 opened a new issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
liwei0423 opened a new issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331
In the company's test environment, the RocketMQ consumer's tag was tampered with by Skywalking
The producer sends the tag as exam, and the consumer receives the topic, which reads the tag as examsw8-x^A0, When Apache Walking is shut down, RocketMQ returns to normal and Tag returns to exam
RocketMQ server 4.9.1
RocketMQ client 4.9.1
Apache Skywalking 8.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wu-sheng commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-947496009
If you have a pull request, I can take a look. Basically, we are sharing the same logic with all RPCs. I will check what do you propose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wu-sheng commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-917386013
FYI, header of sw8-x is following this definition, https://skywalking.apache.org/docs/main/v8.7.0/en/protocols/skywalking-cross-process-propagation-headers-protocol-v3/#extension-header-item
It should have 0- prefix as value, which means this trace should be analyzed to generate metrics and topology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-949422356
@areyouok You could look here :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-915752269
@wu-sheng Could you please look at it, Maybe it's a compatibility issue:-0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wu-sheng commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-916842391
I just checked the codes, SkyWalking's plugin for RocketMQ v4 just uses headers to propagate headers at the producer.
https://github.com/apache/skywalking-java/blob/61892085f95512df5bd8c7c7b67394b40b9f7a1f/apm-sniffer/apm-sdk-plugin/rocketMQ-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/v4/MessageSendInterceptor.java#L65-L77
Is there anything related to your context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] HScarb edited a comment on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
HScarb edited a comment on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-947407514
After debugging rocketmq 4.9.1 and skywalking 8.x, I found out the reason.
It is because this PR of rocketmq https://github.com/apache/rocketmq/pull/2961
https://github.com/apache/rocketmq/blob/fb8bc64e2a2551e76da24cb6af0fb3e5f986f8b3/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java#L442-L444
here add some new codes to delete the last `PROPERTY_SEPARATOR` of `properties`, however skywalking interceptor not expecting it.
I'll post a PR for skywalking soon to solve this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] HScarb commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
HScarb commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-947407514
After debugging rocketmq 4.9.1 and skywalking 8.x, I found out the reason.
It is because this PR of rocketmq https://github.com/apache/rocketmq/pull/2961
https://github.com/apache/rocketmq/blob/fb8bc64e2a2551e76da24cb6af0fb3e5f986f8b3/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java#L442-L444
here add some new codes to delete the last `PROPERTY_SEPARATOR` of `properties`, however skywalking interceptor not expecting it.
I'll post a PR for skywalking soon to solve this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wu-sheng edited a comment on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-916842391
I just checked the codes, SkyWalking's plugin for RocketMQ v4 just uses headers to propagate context at the producer.
https://github.com/apache/skywalking-java/blob/61892085f95512df5bd8c7c7b67394b40b9f7a1f/apm-sniffer/apm-sdk-plugin/rocketMQ-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rocketMQ/v4/MessageSendInterceptor.java#L65-L77
Is there anything related to your context? This is latest codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] wu-sheng commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-915754033
Hi, I am out of office this week. I may be able to check on weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-915720929
So this is the issue of skywalking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on issue #3331: The RocketMQ server is incompatible with the Apache Skywalking service
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #3331:
URL: https://github.com/apache/rocketmq/issues/3331#issuecomment-917373536
Thanks @wu-sheng :-) @liwei0423 Could you mock the implementation to self-padding the properties like wu provided logic. So far, we don't see where the garbled characters come from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org