[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5067: Support ORDER BY an aliased column

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #5067:
URL: https://github.com/apache/arrow-datafusion/pull/5067#discussion_r1094153958


##########
datafusion/sql/tests/integration_test.rs:
##########
@@ -2308,6 +2314,22 @@ fn select_multibyte_column() {
     quick_test(sql, expected);
 }
 
+#[test]
+fn select_groupby_orderby() {
+    let sql = r#"SELECT
+  avg(age) AS "value",
+  date_trunc('month', birth_date) AS "birth_date"
+  FROM person GROUP BY birth_date ORDER BY birth_date;

Review Comment:
   I suggest add more test about qualified column, I think it may cause some problem.
   
   such as use `date_trunc('month', person.birth_date) AS "birth_date"`
   instead of 
   `date_trunc('month', birth_date) AS "birth_date"`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org