[PATCH] Mismatch in db/current when hotcopying old FSFS repositories with propchanges

[Evgeny Kotkov <ev...@visualsvn.com>]

Hi,

I discovered another problem with hotcopy for old FSFS format 1/2 repositories
(apart from those reported in http://svn.haxx.se/dev/archive-2014-01/0089.shtml)
Attempting to hotcopy an old repository with at least one propchange currently
ends up with mismatching node ids in source and destination db/current files.
Here is the patch with a failing test for this problem.

Log message:
[[[
Add a test for the erroneous 'svnadmin hotcopy' behavior for FSFS format 1/2
repositories with at least one propchange.  Hotcopying these repositories
currently ends up with mismatching node ids in source and destination
db/current files.

* subversion/tests/cmdline/svnadmin_tests.py
  (fsfs_hotcopy_old_with_propchanges): New test for the erroneous 'svnadmin
    hotcopy' behavior.  Marked as XFail.
  (test_list): Add reference to new test.

Patch by: Evgeny Kotkov <evgeny.kotkov{_AT_}visualsvn.com>
]]]

I did not have time to examine this issue yet, but might be able to do this in
the nearby future.


Thanks and regards,
Evgeny Kotkov

Re: [PATCH] Mismatch in db/current when hotcopying old FSFS repositories with propchanges

[Evgeny Kotkov <ev...@visualsvn.com>]

Hi Stefan,

> Looks like a reasonable test; please commit.

Committed as r1573730.  Thanks for the review!


Regards,
Evgeny Kotkov

Re: [PATCH] Mismatch in db/current when hotcopying old FSFS repositories with propchanges

[Stefan Fuhrmann <st...@wandisco.com>]

Hi Evgeny,

Looks like a reasonable test; please commit.

-- Stefan^2.


On Mon, Feb 17, 2014 at 10:26 PM, Evgeny Kotkov <evgeny.kotkov@visualsvn.com
> wrote:

> Hi,
>
> I discovered another problem with hotcopy for old FSFS format 1/2
> repositories
> (apart from those reported in
> http://svn.haxx.se/dev/archive-2014-01/0089.shtml)
> Attempting to hotcopy an old repository with at least one propchange
> currently
> ends up with mismatching node ids in source and destination db/current
> files.
> Here is the patch with a failing test for this problem.
>
> Log message:
> [[[
> Add a test for the erroneous 'svnadmin hotcopy' behavior for FSFS format
> 1/2
> repositories with at least one propchange.  Hotcopying these repositories
> currently ends up with mismatching node ids in source and destination
> db/current files.
>
> * subversion/tests/cmdline/svnadmin_tests.py
>   (fsfs_hotcopy_old_with_propchanges): New test for the erroneous 'svnadmin
>     hotcopy' behavior.  Marked as XFail.
>   (test_list): Add reference to new test.
>
> Patch by: Evgeny Kotkov <evgeny.kotkov{_AT_}visualsvn.com>
> ]]]
>
> I did not have time to examine this issue yet, but might be able to do
> this in
> the nearby future.
>
>
> Thanks and regards,
> Evgeny Kotkov
>