[PR] [#FLINK-33596][Connectors/Hive]] Fold expression before transfer function to RexNode [flink-connector-hive]

["yunfan123 (via GitHub)" <gi...@apache.org>]

yunfan123 opened a new pull request, #15:
URL: https://github.com/apache/flink-connector-hive/pull/15

   ## What is the purpose of the change
   Fold expression before transfer function to RexNode.
   Hive will fold expression in optimization stage. 
   But flink-hive-parser use flink optimization.
   And flink can't know some hive function can be constant value.
   
   Some hive code reference:
   
   https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java#L62
   
   https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1776
   
   https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1069
   
   ## Brief change log
   Try to transfer to constant before function transfer to rexNode.
   
   ## Verifying this change
   This change is verified by added test
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [#FLINK-33596][Connectors/Hive]] Fold expression before transfer function to RexNode [flink-connector-hive]

["boring-cyborg[bot] (via GitHub)" <gi...@apache.org>]

boring-cyborg[bot] commented on PR #15:
URL: https://github.com/apache/flink-connector-hive/pull/15#issuecomment-1893774523

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org