You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/04/20 16:46:00 UTC

Review Request 72390: Enabled `LoggingTest*` and `MetricTest*` on Windows.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72390/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10120
    https://issues.apache.org/jira/browse/MESOS-10120


Repository: mesos


Description
-------

Enabled `LoggingTest*` and `MetricTest*` on Windows.


Diffs
-----

  src/tests/CMakeLists.txt e43eb25798db76dc9dabbea87db8908836b505ab 


Diff: https://reviews.apache.org/r/72390/diff/1/


Testing
-------

`make check` on Linux

`.\src\mesos-tests.exe --gtest_filter="LoggingTest*:MetricsTest*" --verbose` on Windows


Thanks,

Andrei Sekretenko


Re: Review Request 72390: Enabled `LoggingTest*` and `MetricTest*` on Windows.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72390/#review220379
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72389, 72390]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 20, 2020, 4:46 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72390/
> -----------------------------------------------------------
> 
> (Updated April 20, 2020, 4:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10120
>     https://issues.apache.org/jira/browse/MESOS-10120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled `LoggingTest*` and `MetricTest*` on Windows.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt e43eb25798db76dc9dabbea87db8908836b505ab 
> 
> 
> Diff: https://reviews.apache.org/r/72390/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on Linux
> 
> `.\src\mesos-tests.exe --gtest_filter="LoggingTest*:MetricsTest*" --verbose` on Windows
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Re: Review Request 72390: Enabled `LoggingTest*` and `MetricTest*` on Windows.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72390/#review220376
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On April 20, 2020, 4:46 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72390/
> -----------------------------------------------------------
> 
> (Updated April 20, 2020, 4:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10120
>     https://issues.apache.org/jira/browse/MESOS-10120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled `LoggingTest*` and `MetricTest*` on Windows.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt e43eb25798db76dc9dabbea87db8908836b505ab 
> 
> 
> Diff: https://reviews.apache.org/r/72390/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on Linux
> 
> `.\src\mesos-tests.exe --gtest_filter="LoggingTest*:MetricsTest*" --verbose` on Windows
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>