You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/06/11 04:05:51 UTC
[PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Aias00 opened a new pull request, #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978
## What
Reject admin JWTs that use non-HMAC signing methods and allow deployments to override the default signing key with `DUBBOGO_PIXIU_JWT_SIGN_KEY`.
## Why
JWT parsing previously returned the verification key without first constraining the token signing method, and deployments only had the hardcoded default signing key path.
## Testing
- `go test ./admin/controller/auth`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#issuecomment-4677229200
close: https://github.com/apache/dubbo-go-pixiu/issues/976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#issuecomment-4951764945
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "Similarityoung (via GitHub)" <gi...@apache.org>.
Similarityoung merged PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on code in PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#discussion_r3393206635
##########
admin/controller/auth/auth_test.go:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package auth
+
+import (
+ "testing"
+ "time"
+)
+
+import (
+ "github.com/golang-jwt/jwt/v4"
+ "github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
+)
Review Comment:
Thanks. This repository enforces imports-formatter in CI rather than plain gofmt grouping; the formatter output keeps separate import blocks and separates third-party groups. I kept the current grouping because the previous CI failure provided this exact formatter diff, and the latest branch keeps that format.
##########
admin/controller/auth/auth.go:
##########
@@ -115,6 +119,9 @@ func (j *JWT) ParseToken(tokenString string) (*CustomClaims, error) {
// Input: token string, custom Claims structure object, custom function
// Parse the token string into jwt's Token structure pointer
token, err := jwt.ParseWithClaims(tokenString, &CustomClaims{}, func(token *jwt.Token) (any, error) {
+ if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
+ return nil, TokenInvalid
+ }
return j.SigningKey, nil
})
Review Comment:
Addressed in bce62c50 by moving the signing-method validation into JWT.keyFunc and reusing it from ParseToken.
##########
admin/controller/auth/auth.go:
##########
@@ -145,6 +152,9 @@ func (j *JWT) RefreshToken(tokenString string) (string, error) {
return time.Unix(0, 0)
}
token, err := jwt.ParseWithClaims(tokenString, &CustomClaims{}, func(token *jwt.Token) (any, error) {
+ if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
+ return nil, TokenInvalid
+ }
return j.SigningKey, nil
})
Review Comment:
Addressed in bce62c50 by reusing JWT.keyFunc from RefreshToken as well, so ParseToken and RefreshToken now share the same signing-method check.
##########
admin/controller/auth/auth.go:
##########
@@ -99,6 +100,9 @@ func NewJWT() *JWT {
// get signKey
func GetSignKey() string {
+ if key := os.Getenv("DUBBOGO_PIXIU_JWT_SIGN_KEY"); key != "" {
+ return key
+ }
return SignKey
Review Comment:
Addressed in bce62c50 by adding jwtSignKeyEnv and reusing it in both GetSignKey and the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#issuecomment-4677117072
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#discussion_r3393175708
##########
admin/controller/auth/auth_test.go:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package auth
+
+import (
+ "testing"
+ "time"
+)
+
+import (
+ "github.com/golang-jwt/jwt/v4"
+ "github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
+)
Review Comment:
Go convention (and `gofmt`) expects a single import block, optionally grouped by blank lines within the same block. Please merge these into one `import (...)` block so the file formats cleanly and matches typical Go style.
##########
admin/controller/auth/auth.go:
##########
@@ -115,6 +119,9 @@ func (j *JWT) ParseToken(tokenString string) (*CustomClaims, error) {
// Input: token string, custom Claims structure object, custom function
// Parse the token string into jwt's Token structure pointer
token, err := jwt.ParseWithClaims(tokenString, &CustomClaims{}, func(token *jwt.Token) (any, error) {
+ if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
+ return nil, TokenInvalid
+ }
return j.SigningKey, nil
})
Review Comment:
The signing-method validation logic is duplicated in both `ParseToken` and `RefreshToken`. To reduce the chance of inconsistencies and simplify future changes (e.g., allowing additional algorithms), factor this callback into a shared helper (e.g., `j.keyFunc()` or `validateHMACSigningMethod(token)`), and reuse it in both places.
##########
admin/controller/auth/auth.go:
##########
@@ -99,6 +100,9 @@ func NewJWT() *JWT {
// get signKey
func GetSignKey() string {
+ if key := os.Getenv("DUBBOGO_PIXIU_JWT_SIGN_KEY"); key != "" {
+ return key
+ }
return SignKey
Review Comment:
The environment variable name is a hard-coded string literal. Consider introducing a package-level constant (e.g., `const jwtSignKeyEnv = \"DUBBOGO_PIXIU_JWT_SIGN_KEY\"`) and using it here (and in tests) to avoid drift and make it easier to change/document in one place.
##########
admin/controller/auth/auth.go:
##########
@@ -145,6 +152,9 @@ func (j *JWT) RefreshToken(tokenString string) (string, error) {
return time.Unix(0, 0)
}
token, err := jwt.ParseWithClaims(tokenString, &CustomClaims{}, func(token *jwt.Token) (any, error) {
+ if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
+ return nil, TokenInvalid
+ }
return j.SigningKey, nil
})
Review Comment:
The signing-method validation logic is duplicated in both `ParseToken` and `RefreshToken`. To reduce the chance of inconsistencies and simplify future changes (e.g., allowing additional algorithms), factor this callback into a shared helper (e.g., `j.keyFunc()` or `validateHMACSigningMethod(token)`), and reuse it in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#issuecomment-4677144346
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.00000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 26.22%. Comparing base ([`4d6cc67`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/4d6cc6733385e3792a500d05317e17a71a35715e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bce62c5`](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/bce62c50ff3383fc0b092222c5bc7e4b9d8beb72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [admin/controller/auth/auth.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978?src=pr&el=tree&filepath=admin%2Fcontroller%2Fauth%2Fauth.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWRtaW4vY29udHJvbGxlci9hdXRoL2F1dGguZ28=) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #978 +/- ##
===========================================
+ Coverage 26.16% 26.22% +0.06%
===========================================
Files 275 275
Lines 21981 21983 +2
===========================================
+ Hits 5751 5765 +14
+ Misses 15621 15607 -14
- Partials 609 611 +2
```
| [Flag](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.22% <75.00%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/978?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#discussion_r3563635442
##########
admin/controller/auth/auth.go:
##########
@@ -144,9 +155,7 @@ func (j *JWT) RefreshToken(tokenString string) (string, error) {
jwt.TimeFunc = func() time.Time {
return time.Unix(0, 0)
}
- token, err := jwt.ParseWithClaims(tokenString, &CustomClaims{}, func(token *jwt.Token) (any, error) {
- return j.SigningKey, nil
- })
+ token, err := jwt.ParseWithClaims(tokenString, &CustomClaims{}, j.keyFunc)
Review Comment:
[P0] `RefreshToken` 在解析前把包级全局 `jwt.TimeFunc` 改成 Unix 0，但解析失败会在第 160 行直接返回，永远不会恢复为 `time.Now`；并发期间普通 `ParseToken` 也会读取这个全局值。一次畸形刷新请求即可让进程后续的过期校验持续失效，合法并发请求也可能接受已过期 Token。必须在修改后立即 `defer` 恢复，并为全局访问加同步；更安全的是不要修改全局时钟，改用 parser/claims 级方式仅忽略本次刷新所需的过期错误。请补充解析失败及并发刷新/校验测试。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#issuecomment-4677082681
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(admin): harden JWT validation [dubbo-go-pixiu]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #978:
URL: https://github.com/apache/dubbo-go-pixiu/pull/978#issuecomment-4677097070
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=978&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=978&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=978)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org