[jira] [Commented] (ZOOKEEPER-1640) dynamically load class objects instead of hard code

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571203#comment-13571203 ] 

Hadoop QA commented on ZOOKEEPER-1640:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12567984/zookeeper.patch
  against trunk revision 1441922.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1386//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1386//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1386//console

This message is automatically generated.
                
> dynamically load class objects instead of hard code
> ---------------------------------------------------
>
>                 Key: ZOOKEEPER-1640
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1640
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>            Reporter: Tian Hong Wang
>              Labels: patch
>             Fix For: 3.4.5
>
>         Attachments: zookeeper.patch
>
>
> Class org.apache.zookeeper.ZooKeeperMain.java uses hard code to load command objects in client site. 
> It need to dynamically load command objects in case of command extension.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira