You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/12/02 09:32:50 UTC
[GitHub] couchdb-fauxton pull request: cors: ui improvements
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/587
cors: ui improvements
- display loading lines at the bottom
- use a button for enabling / disabling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton cors-setting-part2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/587.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #587
----
commit bb02f2dd84560ec6f2dbc1f250e121db390c2b41
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-12-01T14:14:20Z
cors: ui improvements
- display loading lines at the bottom
- use a button for enabling / disabling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161731281
@robertkowalski thanks! (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161473707
@benkeen Green buttons are used not only for success, but for general actions (see database security configuration) while red ones are just used on dark background (see configuration add option). So I don't think there is any rule.
As for notification panel, it has same alien design that fits more Cloudant style rather than CouchDB Fauxton one.
Anyway, I just get caught by your screenshot and thought it worth to point on this issue. I see there is no colour definition on this PR, so this topic is definitely not for here (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161472239
Really? I don't mind it myself. Red and green don't seem applicable for this, and we've used that colour in the compaction and notification panel (class `.btn-info`). But I'm totally game for a colour tweak - not sure what it should be, but I'd argue against red or green which imply error/success to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161730042
agreed @kxepal
changed the button to green and added margin.
good point about the notification center.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161468719
Other than that +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161468499
Looks good! Just one thing: could we give the LoadLines a 20px margin-top, so there's some space between it and the line separating the top? It looks a bit odd (and inconsistent with other pages) being flush with the line:
<img width="871" alt="screen shot 2015-12-02 at 3 42 01 pm" src="https://cloud.githubusercontent.com/assets/512116/11547745/33caa634-990b-11e5-91f9-db35f47602a4.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161477906
Oh I don't know, it seems applicable! :) I'm definitely game for overriding it for something more Fauxton-y (just don't ask me to be the one to pick the colour...), but yeah - it can be handled in a separate ticket for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: cors: ui improvements
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/587#issuecomment-161469023
I may be too late, but why Enable CORS is cyan? It looks alien for Fauxton color scheme. Everywhere else green buttons were used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---