[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM

[GitBox <gi...@apache.org>]

michael-o commented on PR #907:
URL: https://github.com/apache/maven/pull/907#issuecomment-1345626511

   > Several "global" remarks:
   > 
   >     * re empty line: you are arguing with our new code formatter, not me 😄
   
   Darn!
   
   >     * re EXTENSION/"pom" - I did it intentionally like this to make clear that we attach CLASSIFIER/EXTENSION transformed artifact (CLASSIFIER and EXTENSION could be really ANYTHING), while we REPLACE always the POM (so classifier "" and extension "pom"). So I consider your remark as wrong, as EXTENSION currently "just happens" to be same as "pom", we could make it "consumer-super-duper-pom" as well if needed.
   
   I accept this, then the code requires a single line comment to make the intent clear.
   
   >     * re null vs non existent file: as we need and do same as "source" artifact do, we really mimic what it does return, and non-null file but not existing backing file on disk is one of the cases we need to cover.
   
   Hmm, but returning `""` will give `new File("")` which is valid, no?
   
   >     * re sha1: yes, I just inlined it in here but it can be really anything (or just some guava util, but I did not want to use guava, while i did not find anything suitable for this case...)
   
   Yeah, just wanted to express that we did it again.
   
   >     * "it now works".... yes, ITs pass _unmodified_, so this PR achieves same functionality as existing code on master, but it does not use FileTransformer API. OTOH, it "works" with m-gpg-p for reason that "consumer POM" _is present_ as attached artifact from earliest moment, and gpg just finds it and signs it (same for checksum-m-p or whatever other use case). At the end, we "remap" the consumer POM as "main" POM
   
   Ah ok, at the end it will replace the actual POM wioth the consumer POM quite same as maven-shade-plugin can do with the main artifact?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org