You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/08 10:06:09 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

HyukjinKwon opened a new pull request #29679:
URL: https://github.com/apache/spark/pull/29679


   ### What changes were proposed in this pull request?
   
   It should check `IPython` as it's imported as a package. Currently, Sphinx build is being skipped in GitHub Actions as below:
   
   https://github.com/apache/spark/runs/1084164546
   
   ```
   starting python compilation test...
   python compilation succeeded.
   
   starting pycodestyle test...
   pycodestyle checks passed.
   
   starting flake8 test...
   flake8 checks passed.
   
   python3 does not have ipython installed. Skipping Sphinx build for now.
   
   
   all lint-python tests passed!
   ```
   
   ### Why are the changes needed?
   
   To run the documentation builds in Github Actions.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only
   
   ### How was this patch tested?
   
   Manually tested as `dev/lint-python`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-689291703


   Thanks, merging to master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-689291599


   Just confirmed on my local env:
   ```
   $ python3 -c 'import importlib.util; print(importlib.util.find_spec("IPython") is not None)'
   True
   $ python3 -c 'import importlib.util; print(importlib.util.find_spec("ipython") is not None)'
   False
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688769789


   **[Test build #128401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128401/testReport)** for PR 29679 at commit [`61a97a7`](https://github.com/apache/spark/commit/61a97a786e0ae66eb72c2d78723cece599c48fa3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-689240063


   cc @gengliangwang can you take a quick look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688905019


   **[Test build #128401 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128401/testReport)** for PR 29679 at commit [`61a97a7`](https://github.com/apache/spark/commit/61a97a786e0ae66eb72c2d78723cece599c48fa3).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688907626






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688766145






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688907626






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688769789


   **[Test build #128401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128401/testReport)** for PR 29679 at commit [`61a97a7`](https://github.com/apache/spark/commit/61a97a786e0ae66eb72c2d78723cece599c48fa3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gengliangwang closed pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #29679:
URL: https://github.com/apache/spark/pull/29679


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29679: [SPARK-32204][SPARK-32182][DOCS][FOLLOW-UP] Use IPython instead of ipython to check if installed in dev/lint-python

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29679:
URL: https://github.com/apache/spark/pull/29679#issuecomment-688766145






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org