You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by skonto <gi...@git.apache.org> on 2018/10/25 19:18:12 UTC

[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests

GitHub user skonto opened a pull request:

    https://github.com/apache/spark/pull/22838

    [SPARK-25835][K8s] fix issues with k8s tests

    ## What changes were proposed in this pull request?
    
    - Fixes the scala version propagation issue.
    - Disables the tests under the k8s profile, now we will run them manually. Adds a test specific one otherwise tests will not run if we just remove the module from the kubernetes profile.
    ## How was this patch tested?
    Manually by running the tests with different versions of scala.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skonto/spark propagate-scala2.12

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22838
    
----
commit 02894561ba0b3e89d282958ae34087edef857c6f
Author: Stavros Kontopoulos <st...@...>
Date:   2018-10-25T19:15:45Z

    fix issues with k8s tests

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228494668
  
    --- Diff: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh ---
    @@ -103,4 +104,4 @@ then
       properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
     fi
     
    -$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pkubernetes ${properties[@]}
    +$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION -Pkubernetes-integration-tests ${properties[@]}
    --- End diff --
    
    Yes it is needed since kubernetes is not a module of the tests profile. I updated the PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4505/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    @srowen I think now we are aligned.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    @srowen pls review.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4532/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4499/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4532/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98045/testReport)** for PR 22838 at commit [`fc6f740`](https://github.com/apache/spark/commit/fc6f74064268923a67659b5ac7bb1b02138f5879).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4502/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #4397 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4397/testReport)** for PR 22838 at commit [`9b8f6b4`](https://github.com/apache/spark/commit/9b8f6b41cdb0e3139d76a0cfd281c094bcc91469).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98044/testReport)** for PR 22838 at commit [`f446897`](https://github.com/apache/spark/commit/f446897f249690b93dda45fa7696ec467ddd2c87).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Tests failing are unrelated, some flaky hive test.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98050/testReport)** for PR 22838 at commit [`9b8f6b4`](https://github.com/apache/spark/commit/9b8f6b41cdb0e3139d76a0cfd281c094bcc91469).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4503/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98048/testReport)** for PR 22838 at commit [`844cd42`](https://github.com/apache/spark/commit/844cd42112ea59dfaf2875ec977c0a0027db17e3).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228316418
  
    --- Diff: pom.xml ---
    @@ -2654,6 +2654,16 @@
     
         <profile>
           <id>kubernetes</id>
    +      <modules>
    +        <module>resource-managers/kubernetes/core</module>
    +      </modules>
    +    </profile>
    +
    +    <profile>
    +      <id>kubernetes-tests</id>
    +      <activation>
    +      <activeByDefault>false</activeByDefault>
    +      </activation>
    --- End diff --
    
    No just keep this PR


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98044/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228311880
  
    --- Diff: pom.xml ---
    @@ -2654,6 +2654,16 @@
     
         <profile>
           <id>kubernetes</id>
    +      <modules>
    +        <module>resource-managers/kubernetes/core</module>
    +      </modules>
    +    </profile>
    +
    +    <profile>
    +      <id>kubernetes-tests</id>
    +      <activation>
    +      <activeByDefault>false</activeByDefault>
    --- End diff --
    
    Ah right I had https://github.com/apache/spark/pull/22829 open; I can close it in favor of this. 
    Nit: the indent is off here. But, you don't need this section at all. Profiles are not active by default.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22838


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by erikerlandson <gi...@git.apache.org>.

Github user erikerlandson commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    LGTM -  the k8s integration tests are off by default, can be run via `-P...`, and are passwing via Jenkins 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4499/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98048/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98049/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4504/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4502/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228316721
  
    --- Diff: pom.xml ---
    @@ -2654,6 +2654,16 @@
     
         <profile>
           <id>kubernetes</id>
    +      <modules>
    +        <module>resource-managers/kubernetes/core</module>
    +      </modules>
    +    </profile>
    +
    +    <profile>
    +      <id>kubernetes-tests</id>
    +      <activation>
    +      <activeByDefault>false</activeByDefault>
    +      </activation>
    --- End diff --
    
    @srowen @dongjoon-hyun I will use `kubernetes-integration-tests` as the profile from the other pr.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98085/testReport)** for PR 22838 at commit [`0c51cd4`](https://github.com/apache/spark/commit/0c51cd4118aa339a666f03b398eff804e718ffef).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4500/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98045/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98050/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4499/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4503/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98049/testReport)** for PR 22838 at commit [`facd4aa`](https://github.com/apache/spark/commit/facd4aadfa9f1015492a9b896512adfa90b44a4f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4504/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4502/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98047/testReport)** for PR 22838 at commit [`9d25172`](https://github.com/apache/spark/commit/9d25172c6089557c09b033f7f841684a3c23330b).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228317925
  
    --- Diff: pom.xml ---
    @@ -2654,6 +2654,16 @@
     
         <profile>
           <id>kubernetes</id>
    +      <modules>
    +        <module>resource-managers/kubernetes/core</module>
    +      </modules>
    +    </profile>
    +
    +    <profile>
    +      <id>kubernetes-tests</id>
    +      <activation>
    +      <activeByDefault>false</activeByDefault>
    --- End diff --
    
    @srowen I just removed it... Yes I know they are just wanted to make it explicit, anyway. Let's merge both ;)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #4397 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4397/testReport)** for PR 22838 at commit [`9b8f6b4`](https://github.com/apache/spark/commit/9b8f6b41cdb0e3139d76a0cfd281c094bcc91469).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98047/testReport)** for PR 22838 at commit [`9d25172`](https://github.com/apache/spark/commit/9d25172c6089557c09b033f7f841684a3c23330b).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4504/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test status success
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4505/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4505/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    I merged to master/2.4 . The key parts here already passed individually.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4500/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228363727
  
    --- Diff: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh ---
    @@ -103,4 +104,4 @@ then
       properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
     fi
     
    -$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pkubernetes ${properties[@]}
    +$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION -Pkubernetes-integration-tests ${properties[@]}
    --- End diff --
    
    @skonto don't you need `-Pkubernetes` here too?
    Otherwise, I don't even think we need to wait for another test. The exact POM change above just passed in the other PR and this part won't be tested anyway. I tested the SCALA_VERSION evaluation manually and it works.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Posted by skonto <gi...@git.apache.org>.

Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228318094
  
    --- Diff: pom.xml ---
    @@ -2654,6 +2654,16 @@
     
         <profile>
           <id>kubernetes</id>
    +      <modules>
    +        <module>resource-managers/kubernetes/core</module>
    +      </modules>
    +    </profile>
    +
    +    <profile>
    +      <id>kubernetes-tests</id>
    +      <activation>
    +      <activeByDefault>false</activeByDefault>
    --- End diff --
    
    I modified the profile to `Pkubernetes-integration-tests`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    **[Test build #98050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98050/testReport)** for PR 22838 at commit [`9b8f6b4`](https://github.com/apache/spark/commit/9b8f6b41cdb0e3139d76a0cfd281c094bcc91469).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4500/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    I'll spin it one more time just to try to get a green light, but I agree, this change really isn't even testable by the existing tests.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Kubernetes integration test starting
    URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4532/



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22838
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org