You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/23 19:57:47 UTC

[GitHub] [superset] junlincc commented on pull request #12705: feat(explore): allow opening charts with missing dataset

junlincc commented on pull request #12705:
URL: https://github.com/apache/superset/pull/12705#issuecomment-766169758


   I agree - this offers better UX. thanks for the (mid-term) solution. sad to see the toast message go though. Thank you both! @kkucharc @ktmud 🙏
   LGTM 
   https://user-images.githubusercontent.com/67837651/105612528-a8d2b180-5d71-11eb-90e7-57a4ad15cd98.mov
   
   cc @mihir174 we can tweak the styling and msg content later. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org