You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/05/26 15:50:58 UTC

Re: svn commit: r1127904 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On May 26, 2011 9:39 AM, <ju...@apache.org> wrote:
>
> Author: julianfoad
> Date: Thu May 26 13:38:37 2011
> New Revision: 1127904
>
> URL: http://svn.apache.org/viewvc?rev=1127904&view=rev
> Log:
> * subversion/libsvn_wc/wc_db.c
>  (insert_external_node): Move a local variable inside the conditional
block
>    that uses it so it doesn't shadow a variable in the outer scope.

But it still shadows on some builds. That sounds bad.

Re: svn commit: r1127904 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

Posted by Julian Foad <ju...@wandisco.com>.

On Thu, 2011-05-26 at 09:50 -0400, Greg Stein wrote:
> On May 26, 2011 9:39 AM, <ju...@apache.org> wrote:
> >
> > Author: julianfoad
> > Date: Thu May 26 13:38:37 2011
> > New Revision: 1127904
> >
> > URL: http://svn.apache.org/viewvc?rev=1127904&view=rev
> > Log:
> > * subversion/libsvn_wc/wc_db.c
> >  (insert_external_node): Move a local variable inside the conditional
> block
> >    that uses it so it doesn't shadow a variable in the outer scope.
> 
> But it still shadows on some builds. That sounds bad.

No, the outer variable is conditional on the opposite condition.

- Julian