[GitHub] [spark] viirya commented on a change in pull request #29693: [SPARK-32831][SS] Refactor SupportsStreamingUpdate to represent actual meaning of the behavior

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #29693:
URL: https://github.com/apache/spark/pull/29693#discussion_r485795016



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/console.scala
##########
@@ -73,12 +73,11 @@ object ConsoleTable extends Table with SupportsWrite {
   }
 
   override def newWriteBuilder(info: LogicalWriteInfo): WriteBuilder = {
-    new WriteBuilder with SupportsTruncate with SupportsStreamingUpdate {
+    new WriteBuilder with SupportsTruncate with SupportsStreamingUpdateAsAppend {
       private val inputSchema: StructType = info.schema()
 
       // Do nothing for truncate/update. Console sink is special and it just prints all the records.

Review comment:
       nit: remove update in the comment?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org