You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dennis Lundberg <de...@apache.org> on 2012/08/10 22:43:38 UTC
Running ITs only with Maven 3 (was: Re: [VOTE] Release Maven Surefire
Plugin version 2.12.2)
On 2012-08-07 03:03, Kristian Rosenvold wrote:
> Hi,
<snip/>
> We have added maven 2.2.1 runs to jenkins. Although a few IT's are
> still not green, I have individually verified that this are IT's that
> rely on m3's higher precision in
> pom evalutation/execution, so we need to find some way to ignore these
> tests for 2.2.1; I do not consider this a problem.
<snip/>
This can be done by adding a file called invoker.properties in the root
directory of each IT in question. The content of that file should be
like this, if you want the IT to be run only when invoked by Maven 3:
invoker.maven.version = 3.0+
We have several ITs like these in the Site Plugin. Have a look at these two:
https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-site-plugin/src/it/inheritedReports/invoker.properties
https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-site-plugin/src/it/MSITE-484/invoker.properties
Which ITs in Surefire need this? According to Jenkins it's only this one:
Running org.apache.maven.surefire.its.UnicodeTestNamesIT
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.036
sec <<< FAILURE!
When I tried to build the current Surefire trunk using Maven 2.2.1 I get
this error. What am I doing wrong?
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] The projects in the reactor contain a cyclic reference: Edge
between 'Vertex{label='org.apache.maven.surefire:surefire-api'}' and
'Vertex{label='org.apache.maven.surefire:surefire-shadefire'}'
introduces to cycle in the graph
org.apache.maven.surefire:surefire-shadefire -->
org.apache.maven.surefire:surefire-api -->
org.apache.maven.surefire:surefire-shadefire
Is this a known issue?
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Running ITs only with Maven 3 (was: Re: [VOTE] Release Maven
Surefire Plugin version 2.12.2)
Posted by Kristian Rosenvold <kr...@gmail.com>.
Ok, I see there's no end to how much grief that test is causing on
freebsd; the build is still failing even though I added the check. I
figured it would be a fun test to write; but obviously it looks like
we're not really ready for hardcore unicode characters in java file
names; I'll resolve this somehow tomorrow.
Kristian
2012/8/10 Kristian Rosenvold <kr...@gmail.com>:
> I just fixed the 2.2.1 issue in r1371335, by using JUnit4 @Categories,
> the maven 2.2.1 profile uses
> <excludedGroups>org.apache.maven.surefire.its.Not2xCompatible</excludedGroups>
> in the surefire configuration. Surefire runs IT's with
> JUnit47/verifier, not invoker.
>
> As for UnicodeTestNamesIT, it's an IT I just created that contains
> chinese characters in the test class name. It works on linux, but
> fails miserably on freebsd and probably other platforms/filesystems.
> In r1371804 I added a JUnit assumption that checks that the .java file
> is represented correctly in the file system (so the test will be
> ignored if the source file is misrepresented in your local filesystem)
>
> The project is located at
> https://svn.apache.org/repos/asf/maven/surefire/trunk/surefire-integration-tests/src/test/resources/unicode-testnames
> (run with mvn -Dsurefire.version=2.12.2 test), it'd be interesting to
> get some feedback on which os'es that test might pass on - just out of
> curiosity ;)
>
> Kristian
>
>
>
>
> 2012/8/10 Dennis Lundberg <de...@apache.org>:
>> On 2012-08-07 03:03, Kristian Rosenvold wrote:
>>> Hi,
>>
>> <snip/>
>>
>>> We have added maven 2.2.1 runs to jenkins. Although a few IT's are
>>> still not green, I have individually verified that this are IT's that
>>> rely on m3's higher precision in
>>> pom evalutation/execution, so we need to find some way to ignore these
>>> tests for 2.2.1; I do not consider this a problem.
>>
>> <snip/>
>>
>> This can be done by adding a file called invoker.properties in the root
>> directory of each IT in question. The content of that file should be
>> like this, if you want the IT to be run only when invoked by Maven 3:
>>
>> invoker.maven.version = 3.0+
>>
>> We have several ITs like these in the Site Plugin. Have a look at these two:
>> https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-site-plugin/src/it/inheritedReports/invoker.properties
>> https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-site-plugin/src/it/MSITE-484/invoker.properties
>>
>> Which ITs in Surefire need this? According to Jenkins it's only this one:
>>
>> Running org.apache.maven.surefire.its.UnicodeTestNamesIT
>> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.036
>> sec <<< FAILURE!
>>
>>
>> When I tried to build the current Surefire trunk using Maven 2.2.1 I get
>> this error. What am I doing wrong?
>>
>> [INFO]
>> ------------------------------------------------------------------------
>> [ERROR] BUILD FAILURE
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] The projects in the reactor contain a cyclic reference: Edge
>> between 'Vertex{label='org.apache.maven.surefire:surefire-api'}' and
>> 'Vertex{label='org.apache.maven.surefire:surefire-shadefire'}'
>> introduces to cycle in the graph
>> org.apache.maven.surefire:surefire-shadefire -->
>> org.apache.maven.surefire:surefire-api -->
>> org.apache.maven.surefire:surefire-shadefire
>>
>> Is this a known issue?
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Running ITs only with Maven 3 (was: Re: [VOTE] Release Maven
Surefire Plugin version 2.12.2)
Posted by Kristian Rosenvold <kr...@gmail.com>.
I just fixed the 2.2.1 issue in r1371335, by using JUnit4 @Categories,
the maven 2.2.1 profile uses
<excludedGroups>org.apache.maven.surefire.its.Not2xCompatible</excludedGroups>
in the surefire configuration. Surefire runs IT's with
JUnit47/verifier, not invoker.
As for UnicodeTestNamesIT, it's an IT I just created that contains
chinese characters in the test class name. It works on linux, but
fails miserably on freebsd and probably other platforms/filesystems.
In r1371804 I added a JUnit assumption that checks that the .java file
is represented correctly in the file system (so the test will be
ignored if the source file is misrepresented in your local filesystem)
The project is located at
https://svn.apache.org/repos/asf/maven/surefire/trunk/surefire-integration-tests/src/test/resources/unicode-testnames
(run with mvn -Dsurefire.version=2.12.2 test), it'd be interesting to
get some feedback on which os'es that test might pass on - just out of
curiosity ;)
Kristian
2012/8/10 Dennis Lundberg <de...@apache.org>:
> On 2012-08-07 03:03, Kristian Rosenvold wrote:
>> Hi,
>
> <snip/>
>
>> We have added maven 2.2.1 runs to jenkins. Although a few IT's are
>> still not green, I have individually verified that this are IT's that
>> rely on m3's higher precision in
>> pom evalutation/execution, so we need to find some way to ignore these
>> tests for 2.2.1; I do not consider this a problem.
>
> <snip/>
>
> This can be done by adding a file called invoker.properties in the root
> directory of each IT in question. The content of that file should be
> like this, if you want the IT to be run only when invoked by Maven 3:
>
> invoker.maven.version = 3.0+
>
> We have several ITs like these in the Site Plugin. Have a look at these two:
> https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-site-plugin/src/it/inheritedReports/invoker.properties
> https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-site-plugin/src/it/MSITE-484/invoker.properties
>
> Which ITs in Surefire need this? According to Jenkins it's only this one:
>
> Running org.apache.maven.surefire.its.UnicodeTestNamesIT
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.036
> sec <<< FAILURE!
>
>
> When I tried to build the current Surefire trunk using Maven 2.2.1 I get
> this error. What am I doing wrong?
>
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] The projects in the reactor contain a cyclic reference: Edge
> between 'Vertex{label='org.apache.maven.surefire:surefire-api'}' and
> 'Vertex{label='org.apache.maven.surefire:surefire-shadefire'}'
> introduces to cycle in the graph
> org.apache.maven.surefire:surefire-shadefire -->
> org.apache.maven.surefire:surefire-api -->
> org.apache.maven.surefire:surefire-shadefire
>
> Is this a known issue?
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org