You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by ad-os <gi...@git.apache.org> on 2016/07/19 18:15:51 UTC
[GitHub] incubator-fineract pull request #178: Added notification module
GitHub user ad-os opened a pull request:
https://github.com/apache/incubator-fineract/pull/178
Added notification module
This module will allow developers to integrate notifications with their functionality. Here are some wikis on which you can read more about this module.
1) [Notification Module Design](https://mifosforge.jira.com/wiki/pages/viewpage.action?pageId=133070890)
2) [Notification API Developer User Guide](https://mifosforge.jira.com/wiki/display/MDZ/Notification+API+Developer+User+Guide)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ad-os/incubator-fineract notification
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit c62961b6398913f31ad6a72c256a5c224c09e440
Author: Adhyan <ad...@yahoo.com>
Date: 2016-07-19T14:30:54Z
Added notification module
Added notification module
Added Notification Module
Refactored Code
Refactored Code
Refactored Code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410473
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/CentersApiResource.java ---
@@ -54,7 +54,9 @@
import org.apache.fineract.infrastructure.core.serialization.ToApiJsonSerializer;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88398916
--- Diff: fineract-provider/src/main/java/org/apache/fineract/notification/api/NotificationApiResource.java ---
@@ -0,0 +1,68 @@
+package org.apache.fineract.notification.api;
+
+
+import org.apache.fineract.infrastructure.core.api.ApiRequestParameterHelper;
+import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings;
+import org.apache.fineract.infrastructure.core.serialization.ToApiJsonSerializer;
+import org.apache.fineract.infrastructure.core.service.Page;
+import org.apache.fineract.infrastructure.core.service.SearchParameters;
+import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
+import org.apache.fineract.notification.data.NotificationData;
+import org.apache.fineract.notification.service.NotificationReadPlatformService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+import javax.ws.rs.*;
+import javax.ws.rs.core.Context;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.UriInfo;
+
+@Path("/notifications")
+@Component
--- End diff --
scope should be singleton
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by ad-os <gi...@git.apache.org>.
Github user ad-os commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
I have used jms to publish the generated notifications to a queue(implmented via ActiveMq) and then used the jmslistener to subscribe to that queue and listen for any new notification. More specifically, jms with ActiveMq has been used to make the generation and reception of messages to be asynchronous.
And Thanks for the review :smile: I will work on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88408961
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V234__opening_balaces_setup.sql ---
@@ -36,7 +36,7 @@ INSERT INTO `c_configuration`
)
VALUES
(
- 'office-opening-balances-contra-account',
+ 'officeId-opening-balances-contra-account',
--- End diff --
don't modify existing migration files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88398119
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/SearchParameters.java ---
@@ -75,6 +75,15 @@ public static SearchParameters forClients(final String sqlSearch, final Long off
orderBy, sortOrder, staffId, accountNo, loanId, savingsId, orphansOnly, isSelfUser);
}
+ public static SearchParameters forNotifications(final Integer offset, final Integer limit,
--- End diff --
This new method is not required. You can use SearchParameters.forPagination(...) method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410380
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java ---
@@ -18,29 +18,7 @@
*/
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410407
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java ---
@@ -45,13 +45,16 @@
import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410207
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountsApiResource.java ---
@@ -51,7 +51,10 @@
import org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88398383
--- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java ---
@@ -167,6 +168,12 @@ protected void onSuccessfulAuthentication(HttpServletRequest request,
throws IOException {
super.onSuccessfulAuthentication(request, response, authResult);
AppUser user = (AppUser) authResult.getPrincipal();
+
+ if (notificationReadPlatformService.hasUnreadNotifications(user.getId())) {
--- End diff --
Is notification module supported only for basicauth profile? Don't we support for oauth profile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410274
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/note/service/NoteWritePlatformServiceJpaRepositoryImpl.java ---
@@ -174,7 +174,7 @@ private CommandProcessingResult createLoanTransactionNote(final JsonCommand comm
// return new CommandProcessingResultBuilder() //
--- End diff --
Why getOffice() method is changed to getOfficeId()?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by ad-os <gi...@git.apache.org>.
Github user ad-os commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
I think I have followed the same design as the implementation of business events.
> You no need to modify all API resources
I have used only the publish method call from the API resources like
`this.publisher.publishEvent(Event Object)` similar to what the business design uses i.e `this.businessEventNotifierService.notifyBusinessEventToBeExecuted(some parameters)`
Reasons why me and my mentor(Pranjal) decided to use an external queue :-1
1. if we don't use an external queue we can be at a disadvantage of loosing messages if the listener ceases to stop working.
2. This design follows pub-sub pattern which is nowadays generally used to design notification module.
I think the only difference is that business event design uses a Map to store the list of published events and my implementation uses an external queue.
So, should I refactor like the one suggested by you or proceed with my implementation ?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410510
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java ---
@@ -18,25 +18,6 @@
*/
package org.apache.fineract.portfolio.client.api;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
Have a look at how business events are implemented in Fineract. I believe the same way you can do it asynchronously by listening to required events. By this approach you no need to modify all API resources.
I hope I am clear enough to you :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by ad-os <gi...@git.apache.org>.
Github user ad-os closed the pull request at:
https://github.com/apache/incubator-fineract/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
Have a look at current business events implementation. They won't be triggered from api resources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
You need to listen to the business events and you can push notifications in your message queue. API resourced should not have this changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409047
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V1__mifosplatform-core-ddl-latest.sql ---
@@ -204,7 +204,7 @@ CREATE TABLE IF NOT EXISTS `m_calendar_instance` (
-- ================= end of reference/lookup tables =============
--- End diff --
Don't modify existing migration files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by ad-os <gi...@git.apache.org>.
Github user ad-os commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
Hi Nazeer,
What do you mean by
> API resourced should not have this changes ?
What I have currently refactored is like initiating the business events in the respective API resources and then listening to those business events. Is it good enough ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410313
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResource.java ---
@@ -18,25 +18,6 @@
*/
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409094
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V108__client_has_transfer_office.sql ---
@@ -17,12 +17,12 @@
-- under the License.
--
--- End diff --
Don't modify existing migration files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409750
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/shareproducts/api/ShareDividendApiResource.java ---
@@ -113,6 +119,16 @@ public String createDividendDetail(@PathParam("productId") final Long productId,
CommandWrapper commandWrapper = new CommandWrapperBuilder().createShareProductDividendPayoutCommand(productId)
.withJson(apiRequestBodyAsJson).build();
final CommandProcessingResult commandProcessingResult = this.commandsSourceWritePlatformService.logCommandSource(commandWrapper);
+
--- End diff --
Implement Share account business events and publish on event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
Can you please give more details why do we need to use spring-jms?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410349
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/rescheduleloan/api/RescheduleLoansApiResource.java ---
@@ -40,14 +40,17 @@
import org.apache.fineract.infrastructure.core.exception.UnrecognizedQueryParamException;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410550
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/api/AccountsApiResource.java ---
@@ -38,14 +38,18 @@
import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409571
--- Diff: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/AppUserReadPlatformServiceImpl.java ---
@@ -95,10 +95,8 @@ public PlatformSecurityContext getContext() {
final AppUser currentUser = this.context.authenticatedUser();
--- End diff --
This file should not be part of the PR as I don' see any change in this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410135
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountTransactionsApiResource.java ---
@@ -41,14 +41,17 @@
import org.apache.fineract.infrastructure.core.exception.UnrecognizedQueryParamException;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88408934
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V254__General_Ledger_Report.sql ---
@@ -39,5 +39,5 @@ INSERT INTO `stretchy_report_parameter` (`report_id`, `parameter_id`, `report_pa
INSERT INTO `stretchy_report_parameter` (`report_id`, `parameter_id`, `report_parameter_name`) VALUES
((select sr.id from stretchy_report sr where sr.report_name='GeneralLedgerReport'),
(select sp.id from stretchy_parameter sp where sp.parameter_name='OfficeIdSelectOne'),
- 'office');
+ 'officeId');
--- End diff --
You should not modify the existing migration files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409480
--- Diff: fineract-provider/src/main/java/org/apache/fineract/useradministration/service/PermissionReadPlatformServiceImpl.java ---
@@ -39,11 +46,14 @@
private final JdbcTemplate jdbcTemplate;
private final PlatformSecurityContext context;
+ private final AppUserRepository appUserRepository;
@Autowired
- public PermissionReadPlatformServiceImpl(final PlatformSecurityContext context, final RoutingDataSource dataSource) {
+ public PermissionReadPlatformServiceImpl(final PlatformSecurityContext context, final RoutingDataSource dataSource,
--- End diff --
In read platforms don't use jpa repository. Use jdbc template
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410440
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/group/api/GroupsApiResource.java ---
@@ -53,7 +53,9 @@
import org.apache.fineract.infrastructure.core.serialization.ToApiJsonSerializer;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88396940
--- Diff: fineract-provider/gradle/wrapper/gradle-wrapper.properties ---
@@ -1,6 +1,6 @@
-#Fri Jan 29 13:04:36 IST 2016
+#Tue Jul 19 20:53:11 IST 2016
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-all.zip
--- End diff --
why do we need this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88410183
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/RecurringDepositAccountsApiResource.java ---
@@ -51,7 +51,10 @@
import org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
--- End diff --
Listen to the business event and publish the notification event
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409004
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V228__entity_to_entity_access.sql ---
@@ -56,9 +56,9 @@ CREATE TABLE `m_entity_to_entity_access` (
--- End diff --
Don't modify existing migration files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #178: Added notification module
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/178#discussion_r88409864
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountsApiResource.java ---
@@ -49,7 +49,12 @@
import org.apache.fineract.infrastructure.core.serialization.DefaultToApiJsonSerializer;
--- End diff --
Listen to the business events and publish the corresponding notification event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #178: Added notification module
Posted by ad-os <gi...@git.apache.org>.
Github user ad-os commented on the issue:
https://github.com/apache/incubator-fineract/pull/178
Okay, will do and get back to you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---