You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/25 18:59:43 UTC
[GitHub] [spark] huaxingao opened a new pull request #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
huaxingao opened a new pull request #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696
### What changes were proposed in this pull request?
remove unnecessary MiMa excludes
### Why are the changes needed?
When auditing binary incompatible changes for 3.0, I found several MiMa excludes are not necessary, so remove these.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
run dev/mima to check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#discussion_r384174790
##########
File path: project/MimaExcludes.scala
##########
@@ -316,12 +310,6 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.feature.OneHotEncoderEstimator"),
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.OneHotEncoder"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.transform"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.getInputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.getOutputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.inputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.setInputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.setOutputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.outputCol"),
Review comment:
Is this unnecessary because of SPARK-29565?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591078365
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591148706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118932/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591073517
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118930/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27696: [SPARK-30928][ML] Remove
unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591073155
**[Test build #118930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118930/testReport)** for PR 27696 at commit [`f999857`](https://github.com/apache/spark/commit/f999857653d774f0585ba7a93a54640dab14870b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591014135
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591222512
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27696: [SPARK-30928][ML] Remove
unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591147714
**[Test build #118932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118932/testReport)** for PR 27696 at commit [`f999857`](https://github.com/apache/spark/commit/f999857653d774f0585ba7a93a54640dab14870b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591198868
Yes. This goes into 3.0. @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591736861
Thanks! @srowen @viirya @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#discussion_r384174790
##########
File path: project/MimaExcludes.scala
##########
@@ -316,12 +310,6 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.feature.OneHotEncoderEstimator"),
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.OneHotEncoder"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.transform"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.getInputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.getOutputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.inputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.setInputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.setOutputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.outputCol"),
Review comment:
Is this because of SPARK-29565?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27696: [SPARK-30928][ML] Remove
unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591013370
**[Test build #118930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118930/testReport)** for PR 27696 at commit [`f999857`](https://github.com/apache/spark/commit/f999857653d774f0585ba7a93a54640dab14870b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591073517
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118930/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27696: [SPARK-30928][ML] Remove
unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591077847
**[Test build #118932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118932/testReport)** for PR 27696 at commit [`f999857`](https://github.com/apache/spark/commit/f999857653d774f0585ba7a93a54640dab14870b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591078370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23680/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591077404
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591014146
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23678/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #27696: [SPARK-30928][ML] Remove
unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591013370
**[Test build #118930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118930/testReport)** for PR 27696 at commit [`f999857`](https://github.com/apache/spark/commit/f999857653d774f0585ba7a93a54640dab14870b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591148698
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#discussion_r384203849
##########
File path: project/MimaExcludes.scala
##########
@@ -316,12 +310,6 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.feature.OneHotEncoderEstimator"),
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.OneHotEncoder"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.transform"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.getInputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.getOutputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.inputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.setInputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.setOutputCol"),
- ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.feature.OneHotEncoder.outputCol"),
Review comment:
Yes :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591073506
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591073506
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27696: [SPARK-30928][ML] Remove
unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591735041
Merged to master/3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591148706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118932/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591014135
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591155371
cc @srowen @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27696: [SPARK-30928][ML]
Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591078370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23680/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591078365
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591148698
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591014146
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23678/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27696:
[SPARK-30928][ML] Remove unnecessary MiMa excludes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27696: [SPARK-30928][ML] Remove unnecessary MiMa excludes
URL: https://github.com/apache/spark/pull/27696#issuecomment-591077847
**[Test build #118932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118932/testReport)** for PR 27696 at commit [`f999857`](https://github.com/apache/spark/commit/f999857653d774f0585ba7a93a54640dab14870b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org