You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/14 11:59:55 UTC
[GitHub] NicoK commented on a change in pull request #6551:
[FLINK-10022][network][metrics] add metrics for input/output buffers
NicoK commented on a change in pull request #6551: [FLINK-10022][network][metrics] add metrics for input/output buffers
URL: https://github.com/apache/flink/pull/6551#discussion_r209923661
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
##########
@@ -43,38 +43,74 @@
protected double numBytesInRemotePerSecond;
protected double numBytesOutPerSecond;
- public IOMetrics(Meter recordsIn, Meter recordsOut, Meter bytesLocalIn, Meter bytesRemoteIn, Meter bytesOut) {
+ protected long numBuffersInLocal;
+ protected long numBuffersInRemote;
+ protected long numBuffersOut;
+
+ protected double numBuffersInLocalPerSecond;
+ protected double numBuffersInRemotePerSecond;
+ protected double numBuffersOutPerSecond;
+
+ public IOMetrics(
Review comment:
ok - good to know.
Since there was no description of what needs to be where, I simply added the buffer metrics anywhere I saw the byte and record metrics.
-> So I can/should remove them from `IOMetrics` and related classes and that should be fine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services