You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/30 02:13:23 UTC
[GitHub] [trafficcontrol] jhg03a opened a new issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
jhg03a opened a new issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [ ] bug report
- [ ] new feature / enhancement request
- [x] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [x] Traffic Ops
- [ ] Traffic Ops ORT
- [x] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When I was creating a Static DNS CNAME record, I added `domain.foo.com` to a new DS and snapshotted.
This causes the snapshot to fail to apply with no user feedback except to go dig around in TR logs.
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Please remove the footgun of forgetting the trailing dot in the CNAME address and better safeties to prevent it from becoming part of a snapshot.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
1. Add a staticDNS CNAME record with address lacking the final period.
2. Snapshot
3. Observe the Snapshot fails to apply
4. Add a trailing period to the address field of record from 1.
5. Snapshot
6. Observe things work after head banging
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
WARN 2020-05-30T01:57:54.921 [New I/O worker #8] com.comcast.cdn.traffic_control.traffic_router.core.util.PeriodicResourceUpdater - 'ccr.testds.cdn.domain.com' is not an absolute name
org.xbill.DNS.RelativeNameException: 'domain.foo.com' is not an absolute name
at org.xbill.DNS.Record.checkName(Record.java:721)
at org.xbill.DNS.SingleNameBase.<init>(SingleNameBase.java:33)
at org.xbill.DNS.SingleCompressedNameBase.<init>(SingleCompressedNameBase.java:23)
at org.xbill.DNS.CNAMERecord.<init>(CNAMERecord.java:28)
at com.comcast.cdn.traffic_control.traffic_router.core.dns.ZoneManager.addStaticDnsEntries(ZoneManager.java:703)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-638229851
also, when fixing this form. the "address" field is ambiguous and apparently has some rules that must be followed or you'll get this error in TR:
`org.xbill.DNS.RelativeNameException: 'foo' is not an absolute name`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-672941627
fixed per #4934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-636264045
Reading stack traces and digging through 3rd party library source code to find out what "Absolute" means is not something operators can afford to be doing during an outage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-636261814
So is the preferred solution to make it so that a CNAME _can_ be added without a trailing <kbd>.</kbd> or so that such CNAMEs would be rejected by the API?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-638230744
also, i added the `bug` label because missing validation feels like a bug to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a edited a comment on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
jhg03a edited a comment on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-636264045
Triaging silent errors, reading stack traces, and digging through 3rd party library source code to find out what "Absolute" means is not something operators can afford to be doing during an outage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 closed issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 closed issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-638229851
this is the error you get if you leave out the trailing dot.
`org.xbill.DNS.RelativeNameException: 'foo' is not an absolute name`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-663204700
CNAME is where I found it. In theory it would be anywhere we specify the Dns name of a record that uses that library to validate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-636262190
Or at least update the documentation with a CNAME example showing it's a requirement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 edited a comment on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
rimashah25 edited a comment on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-663203030
@jhg03a : Does the trailing period affect only DNS type cname_record or the other 3 as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-638229851
also, when fixing this form in TP. the "address" field is ambiguous and apparently has some rules that must be followed or you'll get this error in TR:
`org.xbill.DNS.RelativeNameException: 'foo' is not an absolute name`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-657586601
I put the `major` label on this as it will block a snapshot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-663203030
jh03a: Does the trailing period affect only DNS type cname_record or the other 3 as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-638228725
when you create a federation cname, you have to add the trailing dot. i say we keep it consistent and just require the trailing dot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #4743: Remove absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-636262086
Yes. Implementer's choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-638233253
I also changed the title @jhg03a - hope you don't mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on issue #4743: Validate absolute DNS name requirement on StaticDNS CNAME
Posted by GitBox <gi...@apache.org>.
jhg03a commented on issue #4743:
URL: https://github.com/apache/trafficcontrol/issues/4743#issuecomment-639760370
> Yes. Implementer's choice.
That's fine. It just needs a helpful message to go with and not just "denied"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org