You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "Joshua Cohen (JIRA)" <ji...@apache.org> on 2015/05/20 20:45:02 UTC
[jira] [Updated] (AURORA-1327) MesosSchedulerImpl should check if
reason is present when posting status updates
[ https://issues.apache.org/jira/browse/AURORA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joshua Cohen updated AURORA-1327:
---------------------------------
Description:
We export stats based on task statuses, however since protobuf enums default to a value when unset, the reason stats we generate may not be correct. c.f https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java#L228. If reason is unset, it will default to the first enum value ({{REASON_COMMAND_EXECUTOR_FAILED}}).
We should call {{status.hasReason()}} first and if it's not set, do not use the value of {{status.getReason()}}.
was:
We export stats based on task statuses, however since protobuf enums default to a value when unset, the reason stats we generate may not be correct. c.f https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java#L228. If reason is unset, it will default to the first enum value (REASON_COMMAND_EXECUTOR_FAILED).
We should call {{status.hasReason()}} first and if it's not set, do not use the value of {{status.getReason()}}.
> MesosSchedulerImpl should check if reason is present when posting status updates
> --------------------------------------------------------------------------------
>
> Key: AURORA-1327
> URL: https://issues.apache.org/jira/browse/AURORA-1327
> Project: Aurora
> Issue Type: Task
> Components: Scheduler
> Reporter: Joshua Cohen
>
> We export stats based on task statuses, however since protobuf enums default to a value when unset, the reason stats we generate may not be correct. c.f https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java#L228. If reason is unset, it will default to the first enum value ({{REASON_COMMAND_EXECUTOR_FAILED}}).
> We should call {{status.hasReason()}} first and if it's not set, do not use the value of {{status.getReason()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)